Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving fopen behaviour for Swift in files_external #19001

Closed
wants to merge 1 commit into from
Closed

Improving fopen behaviour for Swift in files_external #19001

wants to merge 1 commit into from

Conversation

tjdett
Copy link
Contributor

@tjdett tjdett commented Sep 14, 2015

Provides proper behaviour for fopen flags x and a:

  • x - fopen fails if the file exists
  • a - fopen sets the file pointer to the end of the file

@scrutinizer-notifier
Copy link

A new inspection was created.

@karlitschek
Copy link
Contributor

@butonic what do you think?

@LukasReschke
Copy link
Member

@owncloud-bot This is okay to test.

@DeepDiver1975 CLA bot? ;-)

@butonic
Copy link
Member

butonic commented Sep 14, 2015

👍

@butonic
Copy link
Member

butonic commented Sep 14, 2015

wait for #14077, then rebase please

@DeepDiver1975 DeepDiver1975 added this to the 9.0-next milestone Sep 23, 2015
@MorrisJobke MorrisJobke mentioned this pull request Dec 7, 2015
Merged
@MorrisJobke
Copy link
Contributor

I did a copy of this in #20980 - this allows our CI to run the Swift tests.

@MorrisJobke MorrisJobke closed this Dec 7, 2015
@MorrisJobke
Copy link
Contributor

#20980 was merged.

@tjdett tjdett mentioned this pull request Dec 7, 2015
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
app:files_external
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
8 participants
@tjdett @scrutinizer-notifier @karlitschek @LukasReschke @butonic @MorrisJobke @PVince81 @DeepDiver1975