add test framework for doing full request webdav tests #18127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param ExceptionPlugin $exceptionPlugin | ||
| * @return Server | ||
| */ | ||
| protected function getSabreServer(View $view, $user, $password, ExceptionPlugin $exceptionPlugin) { |
There was a problem hiding this comment.
Please move this into a real class instead of duplicating the init code.
Then use that method also from remote.php.
|
Otherwise this is a nice addition. 😄 |
icewind1991
force-pushed
the
dav-request-tests
branch
from
5f21820 to
779e75b
Compare
|
jenkins passed on ci-pr |
|
@DeepDiver1975 @PVince81 @MorrisJobke can this be merged? |
| @@ -33,51 +33,23 @@ | |||
| // Turn off output buffering to prevent memory problems | |||
| \OC_Util::obEnd(); | |||
|
|
|||
| $serverFactory = new \OC\Connector\Sabre\ServerFactory( | |||
|
@owncloud-bot retest this please |
|
|
||
| // Load plugins | ||
| $defaults = new \OC_Defaults(); | ||
| $server->addPlugin(new \OC\Connector\Sabre\BlockLegacyClientPlugin($this->config)); |
There was a problem hiding this comment.
When comparing the lists, this one also isn't present in publicwebdav. Let's hope this won't cause side effects.
|
@icewind1991 please have a look |
icewind1991
force-pushed
the
dav-request-tests
branch
from
b9284db to
b7cbff2
Compare
|
A new inspection was created. |
Fixed |
|
👍 works |
|
🚀 Test PASSed.🚀 |
1 similar comment
|
🚀 Test PASSed.🚀 |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Aug 12, 2015
add test framework for doing full request webdav tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easy to write test that emulate a full webdav request, including all the sabre logic.
The tests are initially meant for #17811 but I figured it would be better to review this seperately.
cc @DeepDiver1975 @PVince81