Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hint to exception #16798

Merged
merged 1 commit into from
Jun 8, 2015
Merged

add hint to exception #16798

merged 1 commit into from
Jun 8, 2015

Conversation

schiessle
Copy link
Contributor

add translatable hint to exception to improve error messages, displayed to the user.

@schiessle schiessle added this to the 8.1-current milestone Jun 8, 2015
@karlitschek
Copy link
Contributor

👍

1 similar comment
@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975
Copy link
Member

unit tests are failing because of #16796

@DeepDiver1975
Copy link
Member

unit tests are failing because of #16796

merged

@DeepDiver1975
Copy link
Member

@owncloud-bot retest this please

@ghost
Copy link

ghost commented Jun 8, 2015

💣 Test FAILed. 💣

nooo432

@DeepDiver1975
Copy link
Member

@schiesbn

Regression

OCA\Encryption\Tests\lib\Crypto\EncryptionTest.testDecrypt (from OCA_Encryption_Tests_lib_Crypto_EncryptionTest)
Failing for the past 1 build (Since Failed#12729 )
Took 19 ms.
add description
Stacktrace

OCA\Encryption\Tests\lib\Crypto\EncryptionTest::testDecrypt
Failed asserting that exception message 'Can not decrypt this file,
probably this is a shared file.
Please ask the file owner to reshare the file with you.' contains 'Can not decrypt this file, probably this is a shared file. Please ask the file owner to reshare the file with you.'.

@schiessle
Copy link
Contributor Author

I will look into it

@schiessle schiessle force-pushed the enc_add_hint_to_exception branch from 02e55dd to d743d6d Compare June 8, 2015 19:18
@scrutinizer-notifier
Copy link

A new inspection was created.

@schiessle
Copy link
Contributor Author

@owncloud-bot retest this please

@ghost
Copy link

ghost commented Jun 8, 2015

🚀 Test PASSed.🚀
chuck

@schiessle
Copy link
Contributor Author

test passed

schiessle added a commit that referenced this pull request Jun 8, 2015
@schiessle
Merge pull request #16798 from owncloud/enc_add_hint_to_exception
2ae2da5 
add hint to exception
@schiessle schiessle merged commit 2ae2da5 into master Jun 8, 2015
@schiessle schiessle deleted the enc_add_hint_to_exception branch June 8, 2015 20:28
@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@schiessle @karlitschek @DeepDiver1975 @scrutinizer-notifier