Check if cURL supports the desired features #16269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of cURL that are unfortunately still bundled by distributors don't support these features which will result in errors and other possibly unpredictable behaviour. Fixes #16179 for master – stable8 requires another patch.
|
Stable8 PR is at #16270 |
|
A new inspection was created. |
|
👍 |
1 similar comment
|
👍 |
MorrisJobke
added a commit
that referenced
this pull request
May 12, 2015
Check if cURL supports the desired features
mmattel
pushed a commit
to mmattel/core
that referenced
this pull request
May 22, 2015
Check if cURL supports the desired features
|
Just checked that libcurl3 in ubuntu 12.04 is 7.22, in cent os 6 is 7.19.7 and CURLOPT_PROTOCOLS and CURLOPT_PROTOCOLS_REDIR were added in curl 7.19.4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of cURL that are unfortunately still bundled by distributors don't support these features which will result in errors and other possibly unpredictable behaviour.
Fixes #16179 for master – stable8 requires another patch. This is the same approach as I used for SabreDAV in sabre-io/http@59179fd
cc @MorrisJobke @nickvergessen Please review and test.