Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webdav access for public reshare #15814

Merged
merged 4 commits into from
Apr 23, 2015
Merged

Fix webdav access for public reshare #15814

merged 4 commits into from
Apr 23, 2015

Conversation

icewind1991
Copy link
Contributor

@karlitschek
Copy link
Contributor

👍

*/
namespace OCA\Files_Sharing\Tests;

class ReadOnlyCache extends TestCase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icewind1991 why delete the unit tests ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the ReadOnlyCache is no longer used, I forgot to also delete the source file though...

fixed now

@PVince81
Copy link
Contributor

  • BUG: it seems inner reshare isn't resolved properly

@PVince81
Copy link
Contributor

Fixes #15758

@PVince81
Copy link
Contributor

Fixes #15600

@ghost
Copy link

ghost commented Apr 22, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11750/
🚀 Test PASSed.🚀
chuck

@MorrisJobke MorrisJobke added this to the 8.1-current milestone Apr 22, 2015
@icewind1991
Copy link
Contributor Author

BUG: it seems inner reshare isn't resolved properly

Fixed

@ghost
Copy link

ghost commented Apr 23, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11762/
🚀 Test PASSed.🚀
chuck

@scrutinizer-notifier
Copy link

The inspection completed: 3 new issues

@DeepDiver1975
Copy link
Member

@PVince81 care to retest? THX

@PVince81
Copy link
Contributor

Yes, on my TODO list

@PVince81
Copy link
Contributor

Works properly now 👍

PVince81 pushed a commit that referenced this pull request Apr 23, 2015
Fix webdav access for public reshare
@PVince81 PVince81 merged commit a672e9d into master Apr 23, 2015
@PVince81 PVince81 deleted the public-reshare-webdav branch April 23, 2015 13:28
@PVince81
Copy link
Contributor

@karlitschek backport to stable8 and stable7 ?

@DeepDiver1975
Copy link
Member

@karlitschek backport to stable8 and stable7 ?

I'd say yes - @icewind1991 please repare prs for stable7 and stable8 - THX

@karlitschek
Copy link
Contributor

yes. backport please

@icewind1991
Copy link
Contributor Author

mmattel pushed a commit to mmattel/core that referenced this pull request May 22, 2015
@MorrisJobke MorrisJobke mentioned this pull request Jul 2, 2015
@davitol
Copy link
Contributor

davitol commented Jul 2, 2015

👍 Works great in version":"8.1.0.8","versionstring":"8.1 RC2"

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants