Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable8] Backport 14766 compare array insertifnotexists #14914

Merged
merged 13 commits into from
Mar 26, 2015

Conversation

nickvergessen
Copy link
Contributor

@ghost
Copy link

ghost commented Mar 16, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10474/
Test PASSed.

@karlitschek
Copy link
Contributor

backport as discusse 👍

@DeepDiver1975
Copy link
Member

👎 we wanted to wait a bit before we backport - furthermore recent tests have shown that this approach will not work on Oracel due to clob

@DeepDiver1975 DeepDiver1975 modified the milestones: 8.0.2, 8.0.3-current-maintenance, 8.0.4-next-maintenance Mar 16, 2015
@karlitschek
Copy link
Contributor

@DeepDiver1975 ok. Do you have a timeline for that?

@DeepDiver1975
Copy link
Member

@DeepDiver1975 ok. Do you have a timeline for that?

@nickvergessen and myself will look into this ... let's see ... maybe we merge this in one week from now - or two?

@DeepDiver1975
Copy link
Member

maybe we merge this in one week from now - or two?

... with the fix for oracle for sure 😉

@nickvergessen nickvergessen changed the title [Stable8] Backport 14766 compare array insertifnotexists [WIP] [Stable8] Backport 14766 compare array insertifnotexists Mar 16, 2015
@nickvergessen nickvergessen changed the title [WIP] [Stable8] Backport 14766 compare array insertifnotexists [Stable8] Backport 14766 compare array insertifnotexists Mar 16, 2015
@ghost
Copy link

ghost commented Mar 16, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10510/
Test PASSed.

@nickvergessen
Copy link
Contributor Author

... with the fix for oracle for sure 😉

"Oracle" fix is included now

@nickvergessen
Copy link
Contributor Author

@PVince81 want run your smashbox against this?

@PVince81
Copy link
Contributor

I'm not sure what tests @jnfrmarks ran originally.
Currently running all the tests don't help because some are still expected to fail (cleanup in progress)

@jnfrmarks
Copy link

I ran the test_uploadFiles.py test case multiple times in a row.

@MorrisJobke
Copy link
Contributor

@jnfrmarks @PVince81 I tried to run smashbox against this, but it doesn't work well (stable8 and this branch fails) Let us have a look at this tomorrow

@MorrisJobke
Copy link
Contributor

I ran smashbox 10 times with test_uploadFiles. Before 3 out of 10 runs failed, because of the database error. after this everything works without an error. 👍 from me

@nickvergessen
Copy link
Contributor Author

@DeepDiver1975

@nickvergessen nickvergessen modified the milestones: 8.0.3-current-maintenance, 8.0.4-next-maintenance Mar 26, 2015
@PVince81
Copy link
Contributor

👍

PVince81 pushed a commit that referenced this pull request Mar 26, 2015
…insertifnotexists

[Stable8] Backport 14766 compare array insertifnotexists
@PVince81 PVince81 merged commit c0bcaa4 into stable8 Mar 26, 2015
@PVince81 PVince81 deleted the backport-14766-compare-array-insertifnotexists branch March 26, 2015 15:30
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants