-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stable8] Backport 14766 compare array insertifnotexists #14914
[Stable8] Backport 14766 compare array insertifnotexists #14914
Conversation
Conflicts: lib/private/appframework/db/db.php
…de the real exception
Conflicts: lib/private/appframework/db/db.php
Refer to this link for build results (access rights to CI server needed): |
backport as discusse 👍 |
👎 we wanted to wait a bit before we backport - furthermore recent tests have shown that this approach will not work on Oracel due to clob |
@DeepDiver1975 ok. Do you have a timeline for that? |
@nickvergessen and myself will look into this ... let's see ... maybe we merge this in one week from now - or two? |
... with the fix for oracle for sure 😉 |
Conflicts: lib/private/appframework/db/db.php
Refer to this link for build results (access rights to CI server needed): |
"Oracle" fix is included now |
@PVince81 want run your smashbox against this? |
I'm not sure what tests @jnfrmarks ran originally. |
I ran the test_uploadFiles.py test case multiple times in a row. |
@jnfrmarks @PVince81 I tried to run smashbox against this, but it doesn't work well (stable8 and this branch fails) Let us have a look at this tomorrow |
I ran smashbox 10 times with test_uploadFiles. Before 3 out of 10 runs failed, because of the database error. after this everything works without an error. 👍 from me |
👍 |
…insertifnotexists [Stable8] Backport 14766 compare array insertifnotexists
Backport of #14766
@MorrisJobke @DeepDiver1975 @PVince81 @icewind1991 @LukasReschke