Add check for problematic modules reqtimeout, deflate and pagespeed

[ghost]

Partly fixes #4783 and #14603.

Currently untested and should be just a discussion starting point how to check for such modules.

The checks also works only with mod-php5 and not with php-cgi/php-fpm

MIT licensed

[ghost]

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

[nickvergessen]

you mean if (self::apacheModuleEnabled($checkModule)) ?

[ghost]

@nickvergessen
Thanks for the feedback, just have changed the code as suggested.

[scrutinizer-notifier]

The inspection completed: 2 new issues, 1 updated code elements

[LukasReschke]

New array annotation please while at it :)

['foo']

[LukasReschke]

Do we know if that lead to issues with sharing hosting environments where such modules are enabled but not necessary enabled on every virtual host?

If this is the case then please consider performing some checks using a client-side check: https://github.com/owncloud/core/blob/7e0fd8fb501459f3ff1cfa5ddb40e1c97d50d617/core/js/setupchecks.js – I think the Deflate should be signalized in the response header?

[ghost]

@LukasReschke
Sure, this could be the case on special server configurations but IMHO its better to show more than less infos about problematic server configs/modules.

The client-side check is probably the best way which could also catch "gzip on" (owncloud-archive/documentation#922) and ngx_pagespeed (#14604) enabled NginX servers. So to sum up:

1. mod_deflate and "gzip on" will add the header: Content-Encoding: gzip
2. ngx_pagespeed will add the header: X-Page-Speed: 1.9.32.1-4238
3. mod_pagespeed will add the header: X-Mod-Pagespeed: x.y.z
4. mod_reqtimeout -> Probably not detectable on client-side

I really don't have the knowledge in JS so if this way is preferred some one else have to do this.

[LukasReschke]

mod_deflate and "gzip on" will add the header: Content-Encoding: gzip
ngx_pagespeed will add the header: X-Page-Speed: 1.9.32.1-4238
mod_pagespeed will add the header: X-Mod-Pagespeed: x.y.z

Okay. So I'll take care of those three in another PR and you update this PR accordingly? :)

[ghost]

If only mod_reqtimeout is left we could also just close the PR as this module is documented with owncloud-archive/documentation#897 and probably not that wide-spread as mod_deflate and pagespeed?

[DeepDiver1975]

no string concat please - translation extraction will fail - thx

[ghost]

Hi,

then you might want to fix the whole util.php as this is used on several places. But i will just close the PR as the module check is not very reliable.