Delete orphaned shares in a background job

[PVince81]

Partial fix for #12323
Fixes #14664

• integrate with CleanTags to avoid code duplication: https://github.com/owncloud/core/blob/master/lib/repair/cleantags.php maybe later...

Even though this solves the issue in a "brutal" manner by simply deleting ALL orphaned shares it feels hacky.
I could add code to find all child elements but that would take more time.

@DeepDiver1975 @icewind1991

[icewind1991]

#14644 provides $this->runCommands() for that

[icewind1991]

#14644 is now merged

[PVince81]

I know, I need to get my hands dirty again here 😄

[PVince81]

Fixes #6985

[PVince81]

@MorrisJobke check this out, you asked about the SQL query to delete orphaned shares

[PVince81]

• make it work with SQLite
• make a background job instead of a command
• add unit test

[PVince81]

Added unit test and special case for SQLite.

[MorrisJobke]

Test\BackgroundJob\DeleteOrphanedSharesJobTest::testClearShares
Orphaned shares deleted
Failed asserting that actual size 1 matches expected size 0.

/var/jenkins/workspace/pull-request-analyser-ng-simple/label/SLAVE/apps/files_sharing/tests/deleteorphanedsharesjobtest.php:99

[PVince81]

After discussing with @MorrisJobke we decided to go the sub-query approach which works for all DBs (note that the current approach also fails on PostgreSQL).

I'll make the change.

[PVince81]

• make sure we don't delete non-file shares, need to check item_type

[PVince81]

Retested with a shared address book. I can confirm that only the orphaned folder share was deleted.

[PVince81]

@icewind1991 @nickvergessen @DeepDiver1975 @LukasReschke review ?

[MorrisJobke]

Squashed and jenkins PR update pushed :)

[PVince81]

Individual test pass locally but not on Jenkins, possibly a side-effect of other tests:

12:24:51 1) Test\BackgroundJob\DeleteOrphanedSharesJobTest::testClearShares
12:24:51 Orphaned shares deleted
12:24:51 Failed asserting that actual size 1 matches expected size 0.
12:24:51 
12:24:51 /var/jenkins/workspace/pull-request-analyser-ng-simple@5/label/SLAVE/apps/files_sharing/tests/deleteorphanedsharesjobtest.php:122

I'll see what I can do.

[PVince81]

Rebased onto master

[PVince81]

Jenkins PR: #15457

[PVince81]

Still the same:

05:24:53 1) Test\BackgroundJob\DeleteOrphanedSharesJobTest::testClearShares
05:24:53 Orphaned shares deleted
05:24:53 Failed asserting that actual size 1 matches expected size 0.

[PVince81]

The test doesn't work any more because somehow the trashbin appears and moves the files to trash instead of a full deletion. For some reason it didn't many commits ago.

I'll try and find a solution.

[nickvergessen]

@PVince81 related to storage wrapping?

[scrutinizer-notifier]

A new inspection was created.

[PVince81]

Jenkins PR: #15466

[PVince81]

@nickvergessen yes, but the wrapping is normal here (not a bug).
But for the sake of unit testing, I disabled the trashbin (like we do in other places)

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/11313/
🚀 Test PASSed.🚀

[PVince81]

Tests passed, please review @MorrisJobke @DeepDiver1975 @LukasReschke @nickvergessen

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

maybe @rullzer or @Xenopathic want to review this? ;)

[MorrisJobke]

@LukasReschke @nickvergessen @DeepDiver1975 Reviewers needed :)

[karlitschek]

👍