Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable timeouts of mod_reqtimeout in .htaccess #14607

Closed
wants to merge 1 commit into from
Closed

Disable timeouts of mod_reqtimeout in .htaccess #14607

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2015

closes #14603

Untested as i don't have an running Apache instance. Probably should be also backported to stable8 and stable7.

@ghost
Copy link
Author

ghost commented Feb 28, 2015

Thanks a lot for your contribution! Contributions to the core repo require a signed contributors agreement http://owncloud.org/contribute/agreement/ Alternatively you can add a comment here stating that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@ghost
Copy link
Author

ghost commented Feb 28, 2015

MIT licensed

@@ -49,3 +49,7 @@ Options -Indexes
Header set Cache-Control "max-age=7200, public"
</FilesMatch>
</IfModule>
<IfModule reqtimeout_module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency please use mod_reqtimeout.c

@LukasReschke
Copy link
Member

@owncloud-bot Okay to test

@LukasReschke
Copy link
Member

Besides my nitpick: 👍

@LukasReschke LukasReschke added this to the 8.1-current milestone Feb 28, 2015
@ghost
Copy link
Author

ghost commented Feb 28, 2015

@LukasReschke
Done. The current .htaccess is also using but that should be probably changed with another PR?

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@MorrisJobke
Copy link
Contributor

I got a 500 and this is in the apache error log:

[Sun Mar 01 12:09:11.568133 2015] [core:alert] [pid 13098:tid 139963815405312] [client 127.0.0.1:41705] /home/mjob/Projekte/owncloud/master/.htaccess: RequestReadTimeout not allowed here, referer: http://localhost/master/index.php/settings/admin

@ghost
Copy link
Author

ghost commented Mar 2, 2015

Context: server config, virtual host

from https://httpd.apache.org/docs/current/mod/mod_reqtimeout.html#requestreadtimeout so we can't use this in a .htaccess file -> closed

@ghost ghost closed this Mar 2, 2015
@MorrisJobke MorrisJobke removed this from the 8.1-current milestone Mar 2, 2015
@ghost ghost deleted the mod_reqtimeout branch March 7, 2015 12:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable / detect mod_reqtimeout to avoid upload problems
3 participants