Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup garbage collection for global file cache #14500

Merged
merged 1 commit into from
Feb 25, 2015

Conversation

icewind1991
Copy link
Contributor

Also fixes it to ignore directories (fixes #14389), makes the code testable and adds unit tests.

cc @DeepDiver1975 @PVince81 @oparoz

@PVince81
Copy link
Contributor

👍 makes sense

@karlitschek
Copy link
Contributor

👍

@ghost
Copy link

ghost commented Feb 25, 2015

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/9952/
Test PASSed.

@scrutinizer-notifier
Copy link

The inspection completed: 4 new issues, 10 updated code elements

@DeepDiver1975 DeepDiver1975 added this to the 8.1-next milestone Feb 25, 2015
DeepDiver1975 added a commit that referenced this pull request Feb 25, 2015
Cleanup garbage collection for global file cache
@DeepDiver1975 DeepDiver1975 merged commit 14c592f into master Feb 25, 2015
@DeepDiver1975 DeepDiver1975 deleted the fileglobalgc-cleanup branch February 25, 2015 14:41
@DeepDiver1975
Copy link
Member

@karlitschek issue was reported for OC8 - backport?

@karlitschek
Copy link
Contributor

yes. please backport

@icewind1991
Copy link
Contributor Author

stable8: e82f30c

@PVince81
Copy link
Contributor

@icewind1991 next time please send a PR for backports, to avoid risking to break Jenkins there. (this was decided a few weeks ago)

@icewind1991
Copy link
Contributor Author

ok

@DeepDiver1975
Copy link
Member

@icewind1991 I hope you are subscribed to the mailing list 🙊

https://mailman.owncloud.org/pipermail/devel/2015-January/000964.html

@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unlink() error in log after executing cronjob
5 participants