[Stable7] app upgrade order fix #14040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The inspection completed: 130 new issues, 1 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 |
|
Should we merge this ? Or wait for 7.0.6 maybe ? |
|
should be safe to merge now |
|
That is a nasty one but certainly makes sense. As this is against stable7 the static non-testable code path looks okay 👍 |
LukasReschke
added a commit
that referenced
this pull request
Feb 17, 2015
[Stable7] app upgrade order fix
|
I did an upgrade from 7.0.4 to this branch with all core apps and music, maps, news, contacts and calendar enabled -> works fine. No errors in log 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #13865 to stable7
@blizzz @DeepDiver1975 @icewind1991 @karlitschek @MorrisJobke