[stable7] Fix getItemSharedWithUser for groups #13470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
changed the title
|
Great 👍 |
|
I have retested with the steps from #13361 (comment) |
|
Strange, tests passed for me locally |
Fixed SQL query for whenever a user has more than one group. Added missing $owner where clause for group lookup. Added unit tests for the group cases. Backport of 40931a8 from master
PVince81
force-pushed
the
stable7-share-fixfindshareforuserwithmultiplegroups
branch
from
ed6da64 to
18d46df
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
The inspection completed: 3 new issues, 5 updated code elements |
|
Can we get this important fix merged ? Thanks @schiesbn @MorrisJobke @LukasReschke @DeepDiver1975 |
|
Let me test that. |
|
Works 👍 |
MorrisJobke
added a commit
that referenced
this pull request
Jan 23, 2015
…userwithmultiplegroups [stable7] Fix getItemSharedWithUser for groups
MorrisJobke
deleted the
stable7-share-fixfindshareforuserwithmultiplegroups
branch
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed SQL query for whenever a user has more than one group.
Added missing $owner where clause for group lookup.
Added unit tests for the group cases.
Backport of #13423 to stable7
Please review and test @schiesbn @MorrisJobke @LukasReschke @DeepDiver1975