Fix annotations in file view #13320
Fix annotations in file view #13320
Conversation
| @@ -435,11 +439,18 @@ public function unlink($path) { | |||
|
|
|||
| /** | |||
| * @param string $directory | |||
| * @param bool $empty | |||
There was a problem hiding this comment.
@icewind1991: Where is empty actually used in that method?
There was a problem hiding this comment.
Didn't find a call that uses it, so I guess it could be removed.
There was a problem hiding this comment.
I couldn't find it too.
|
Looks good 👍 |
|
Refer to this link for build results (access rights to CI server needed): |
| /** | ||
| * @param string $path1 | ||
| * @param string $path2 | ||
| * @return bool|mixed |
There was a problem hiding this comment.
mixed includes bool already?
There was a problem hiding this comment.
I actually suspect that the mixed is not going to happen very often but the called functions return null at some point (or possibly other values) – I'd think this makes it cleaner to read.
|
I dropped the useless parameter. |
|
👍 |
|
Refer to this link for build results (access rights to CI server needed): |
MorrisJobke
force-pushed
the
fix-php-doc-for-files-view
branch
from
cbb22ab to
0a400b4
Compare
|
A new inspection was created. |
|
I just dropped the parameter in the PHPDoc too. |
|
still 👍 from me |
Fix annotations in file view
@icewind1991