-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove PHP generated user list and move all to the existing JS part #12790
Conversation
Refer to this link for build results (access rights to CI server needed): |
@LukasReschke But then it's an issue that exists before. Because this just needs to fill the list the first time and then just relies on the (also previously used) JS code |
@MorrisJobke Works fine on master for me. |
Reproducable here too. Will fix this tomorrow. |
cebb930
to
af1f34e
Compare
@LukasReschke I fixed the problem ;) |
I just changed the JS and they run successful local. This is ready for merge |
The inspection completed: 5 new issues |
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 16 lines...]Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git4636580237226817205.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12790/merge^{commit} # timeout=10 > git branch -a --contains 15045c783221a3c88e06a03a89ca304758c779c6 # timeout=10 > git rev-parse remotes/origin/pr/12790/merge^{commit} # timeout=10Checking out Revision 15045c783221a3c88e06a03a89ca304758c779c6 (origin/pr/12790/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 15045c783221a3c88e06a03a89ca304758c779c6First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 1 second💣 Test FAILed. 💣 |
👍 |
👍 failing test is unrelated |
remove PHP generated user list and move all to the existing JS part
I cleaned up the PHP part of the user management. The whole user list is now generated via the existing JS code.
ref #12620
@blizzz @LukasReschke @PVince81 Give this a try and report back problems.
TODO: