Issue/6101 remove namespace permission constants

[nickvergessen]

@bantu @DeepDiver1975

If we do not want to replace the usages, we can remove the second commit.
But I think we can do it
#6101 for reference

[scrutinizer-notifier]

The inspection completed: 2 new issues, 1 updated code elements

[nickvergessen]

@owncloud-bot retest this please

[ghost]

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/3264/

Build result: FAILURE

[...truncated 17 lines...] > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/12421/merge^{commit} # timeout=10Checking out Revision bf41ccefe4b3a3553895cbeeeda484e2a9432782 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f bf41ccefe4b3a3553895cbeeeda484e2a9432782 > git rev-list 1bdcedc3e492b5c8a7b9c215ce797a81b57743ee # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveCleaning workspace > git rev-parse --verify HEAD # timeout=10Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10 > git submodule foreach --recursive git reset --hard # timeout=10 > git submodule foreach --recursive git clean -fdx # timeout=10Triggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 5 second
💣 Test FAILed. 💣

[DeepDiver1975]

same filing unit tests as in master:

Test Result (7 failures / +7)

    Test\TempManager.testGetFile
    Test\TempManager.testGetFolder
    Test\TempManager.testCleanFiles
    Test\TempManager.testCleanFolder
    Test\TempManager.testCleanOld
    Test\TempManager.testLogCantCreateFile
    Test\TempManager.testLogCantCreateFolder

[DeepDiver1975]

looks good from my pov 👍

[bantu]

Generally, the constants should be on the classes related to them. I am not sure whether there is a candidate class for the permission constants. This probably fixes, or rather works around, the problem at hand, though.

[MorrisJobke]

👍

[MorrisJobke]

@nickvergessen I would like you to send a mail to devel and check the documentation. Thanks