[WIP] introduction of interface IChunkHandler and a very first stupid implemen... #12160
Conversation
|
🚀 Test PASSed. 🚀 |
| $complete = false; | ||
| $actualSize = $chunkHandler->getCurrentSize(); | ||
|
|
||
| if ($chunkHandler->isComplete()) { |
There was a problem hiding this comment.
I see, so the last chunk would trigger assembling.
I'm not sure, I'd have moved this to a separate function but am not sure why. Maybe to give the caller more control of when they want to do the assembling.
If you decide to keep it this way, it might be a good idea to at least expose isComplete() on the interface.
|
🚀 Test PASSed. 🚀 |
|
From a first look it looks good. |
|
@karlitschek @schiesbn @icewind1991 @craigpg this approach only appears to be reasonable in case we decide on moving encryption on a different layer of the implementation. From my point of view this is highly necessary to further improve the implementation to fit the needs of upcoming performance tasks/enhancments. |
|
I think this makes sense to be more flexible in the future. would love to hear opinions from @icewind1991 @schiesbn @PVince81 |
|
💣 Test FAILed. 💣 |
…mentation reusing the existing chunking mechanism
DeepDiver1975
force-pushed
the
file-chunking-next-generation
branch
from
fcf6170 to
33fd130
Compare
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 17 lines...]using GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git7250515416477020951.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12160/merge^{commit} # timeout=10 > git branch -a --contains 86703d9f5b8a639619a641e41ece9faf714d3e89 # timeout=10 > git rev-parse remotes/origin/pr/12160/merge^{commit} # timeout=10Checking out Revision 86703d9f5b8a639619a641e41ece9faf714d3e89 (origin/pr/12160/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 86703d9f5b8a639619a641e41ece9faf714d3e89First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 5 minutes💣 Test FAILed. 💣 |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 17 lines...]using GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git7366917722331903229.credentials # timeout=10 > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse origin/pr/12160/merge^{commit} # timeout=10 > git branch -a --contains c192f73f327004fd3eb8d2cd6d8c0b4fc55a7e2e # timeout=10 > git rev-parse remotes/origin/pr/12160/merge^{commit} # timeout=10Checking out Revision c192f73f327004fd3eb8d2cd6d8c0b4fc55a7e2e (origin/pr/12160/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f c192f73f327004fd3eb8d2cd6d8c0b4fc55a7e2eFirst time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 minutes 18 seconds💣 Test FAILed. 💣 |
|
The inspection completed: 9 new issues, 12 updated code elements |
|
Refer to this link for build results (access rights to CI server needed):
|
|
So will we continue this for 8.2 ? |
|
We probably want #17104 first |
yes - there might be no necessity to have storage specific implementations .... |
|
let me close this |
...tation reusing the existing chunking mechanism
🚧
refs #4997
@icewind1991 @PVince81