Convert StorageNotAvailableException to SabreDAV exception #11992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DeepDiver1975 @craigpg @icewind1991 Note: it is expected that the external storage instance will throw |
This was referenced Nov 6, 2014
Closed
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 10 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision 836bc95db5ec5a71139dca4cc0399eedbe2926bc (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 836bc95db5ec5a71139dca4cc0399eedbe2926bc > git rev-list 4b7311919e52776ff9fb41a0b5ddd543ea5638f2 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 5 minutes💣 Test FAILed. 💣 |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 10 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision e5a420af510751bef6dbc0e44666a139a2b3b9f4 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f e5a420af510751bef6dbc0e44666a139a2b3b9f4 > git rev-list f11c81b68aaf2ce0f35cdf81e1b0ba931060cac0 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02Configuration pull-request-analyser-ng-simple » vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 minutes 29 seconds💣 Test FAILed. 💣 |
|
@DeepDiver1975 Jenkins is acting up again |
9 tasks
PVince81
force-pushed
the
sabre-convertstoragenotavailableexception
branch
from
7359938 to
17bd471
Compare
|
Rebased |
PVince81
force-pushed
the
sabre-convertstoragenotavailableexception
branch
from
17bd471 to
7ca7493
Compare
|
Squashed |
|
Setting to gold/showstopper/ship blocker due to #11869 |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 10 lines...] > git config remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision 290c04ba80751507b3ce48d279839470920a6488 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 290c04ba80751507b3ce48d279839470920a6488 > git rev-list ccf35d318667aaba7b9d8b8994bad8a103458beb # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 12 lines...]Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision 290c04ba80751507b3ce48d279839470920a6488 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 290c04ba80751507b3ce48d279839470920a6488 > git rev-list 9d375d1b5409f38c44a8df8d23eb88228cd956fc # timeout=10warning: inexact rename detection was skipped due to too many files.warning: you may want to set your diff.renameLimit variable to at least 1986 and retry the command. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 second💣 Test FAILed. 💣 |
|
👍 see my testing results here: #11869 |
|
See #11994 (comment) |
|
👍 |
|
@owncloud-bot retest this please |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 11 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision 87d9449e7222da14f3a5798255e083f9b4df4f20 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 87d9449e7222da14f3a5798255e083f9b4df4f20 > git rev-list 9d375d1b5409f38c44a8df8d23eb88228cd956fc # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
|
What a weird state... will rebase on master and hope it fixes it. |
Convert \OCP\Files\StorageNotAvailableException to \Sabre\DAV\Exception\ServiceUnavailable for every file/directory operation happening inside of SabreDAV. This is necessary to avoid having the exception bubble up to remote.php which would return an exception page instead of an appropriate response.
PVince81
force-pushed
the
sabre-convertstoragenotavailableexception
branch
from
7ca7493 to
20da1e9
Compare
|
💣 Test FAILed. 💣 |
|
@owncloud-bot retest this please |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 11 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision d5fe0a02e1ec797a3fff4685675ba42810f18848 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f d5fe0a02e1ec797a3fff4685675ba42810f18848 > git rev-list d85a410e7e9e6f9a8702f1f708898242df4efab1 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second💣 Test FAILed. 💣 |
@DeepDiver1975 is that one of Jenkins' known illnesses ? Or should I restart until it works ? |
|
The inspection completed: 2 new issues, 4 updated code elements |
|
@owncloud-bot retest this please |
|
💣 Test FAILed. 💣 Build result: FAILURE[...truncated 11 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Cleaning workspace > git rev-parse --verify HEAD # timeout=10No valid HEAD. Skipping the resetting > git clean -fdx # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11992/merge^{commit} # timeout=10Checking out Revision 6bd74b1 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 6bd74b1 > git rev-list 22bf69d11be01a93d98b15d6529328073294d107 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » vm-slave-02pull-request-analyser-ng-simple » vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 3 second💣 Test FAILed. 💣 |
|
I'll try making a new PR for that... |
|
Here's the new PR: #12072 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert \OCP\Files\StorageNotAvailableException to
\Sabre\DAV\Exception\ServiceUnavailable for every file/directory
operation happening inside of SabreDAV.
This is necessary to avoid having the exception bubble up to remote.php
which would return an exception page instead of an appropriate response.