[WIP] Cleanup filesystem setup code #11091

icewind1991 · 2014-09-15T16:07:21Z

Move the logic of setting up the filesystem from "all over the place" to \OC\Files\Factory
Seperate out logic of setting up the filesystem for object storage based systems (cc @butonic)
Remove filesystem state from \OC\Files\Filesystem
Let the server container keep track of the state instead

cc @DeepDiver1975 @PVince81 @th3fallen

RobinMcCorkell · 2014-09-20T08:20:29Z

cc myself

PVince81 · 2014-10-31T15:33:03Z

I was hoping that at some point we could reach a level where setting up the FS isn't something global/static (which here is still the case even when stored in \OC::$server).

Ideally it should be possible to call setupFS() and get an instance of filesystem for that user, making it possible to have FS instances from multiple users (for example for sharing).

Will this change somehow bring us closer to that ?

icewind1991 · 2014-10-31T15:48:07Z

Some state needs to be global in some way, having multiple instances of storage objects for the "same" storage will lead to problems.

The user specific state should be removed yet, ideally any filesystem calls will be independent of the logged in user.

I'll see if some changes can be made to this PR in that direction

PVince81 · 2014-10-31T15:51:04Z

How about having a "pool" of storage instances, then ? 😄

I'm not expecting you to add changes just yet, just see whether this PR is somehow compatible with that vision 😄

icewind1991 · 2014-10-31T16:27:47Z

I'm not expecting you to add changes just yet, just see whether this PR is somehow compatible with that vision 😄

I know, just making sure this PR doesn't add anything that will make this more difficult in the future

butonic · 2014-11-11T16:22:26Z

@icewind1991 is this ready to review or WIP?

icewind1991 · 2014-11-11T16:33:00Z

There are a few failing test cases that need to be resolved but other than that it's ready for review

PVince81 · 2014-11-26T16:03:09Z

More a refactor than a simply cleanup 😉

PVince81 · 2014-12-09T17:22:21Z

lib/private/files/factory.php

+	}
+
+	/**
+	 * Mount the storages for a user


Make it clearer

"Returns a folder with the point of view of the given user, with all mount points applied"

PVince81 · 2014-12-09T17:30:54Z

lib/private/files/fileinfomanager.php

+
+namespace OC\Files;
+
+class FileInfoManager {


Double check whether it's still needed ?

BernhardPosselt · 2014-12-15T11:24:37Z

lib/private/server.php

+		$this->registerService('FilesystemFactory', function (Server $c) {
+			\OC_App::loadApps(array('filesystem'));
+			$config = $c->getConfig();
+			if ($config->getSystemValue('objectstore', false)) {


This should be moved into a separate factory so you can test it, much like https://github.com/owncloud/news/blob/master/db/mapperfactory.php

PVince81 · 2015-07-03T11:21:23Z

@icewind1991 any update ? Is that the one you are splitting in smaller pieces ?

PVince81 · 2015-09-01T08:47:55Z

Needs rebasing.

Didn't you split this up already partly ?

icewind1991 · 2015-09-01T10:31:22Z

Some of it went in the various other filesystem related PR over the year, but most of it still needs to be done

MorrisJobke · 2015-11-23T11:50:07Z

This PR is over an year old and touches a lot of files that have changed meanwhile. Can this be splitted up in smaller parts to make it easier to review or what is the state of this?

icewind1991 · 2015-11-23T12:18:21Z

Yes, would be better to close this and make new PR(s) when we decide to work on it further

Trying to rebase/update this PR would probably be more work then redoing it

icewind1991 force-pushed the filesystem-factory branch from 1ca74b3 to 75bb96a Compare September 15, 2014 16:12

LukasReschke added the 3 - To Review label Sep 15, 2014

DeepDiver1975 added 1 - To develop and removed 3 - To Review labels Sep 16, 2014

icewind1991 force-pushed the filesystem-factory branch from 75bb96a to 256d87e Compare September 19, 2014 11:47

scolebrook force-pushed the master branch from 4a4ea1d to 9dea79e Compare October 10, 2014 13:32

icewind1991 force-pushed the filesystem-factory branch from 256d87e to 0c808c8 Compare October 21, 2014 13:06

icewind1991 mentioned this pull request Oct 21, 2014

Call to a member function getFileInfo() on a non-object #11584

Closed

icewind1991 force-pushed the filesystem-factory branch 4 times, most recently from b0f00c1 to 0c0c255 Compare October 29, 2014 14:45

icewind1991 force-pushed the filesystem-factory branch 2 times, most recently from f8f3889 to 79843c8 Compare November 7, 2014 14:22

icewind1991 mentioned this pull request Nov 11, 2014

StorageManager, cache userfolder #12099

Closed

PVince81 mentioned this pull request Nov 24, 2014

Make Filesystem / setupFS non-static #12399

Closed

icewind1991 force-pushed the filesystem-factory branch 2 times, most recently from c6a85dd to b3265aa Compare November 26, 2014 13:31

icewind1991 mentioned this pull request Dec 3, 2014

Add a public api for apps to add mounts #12577

Merged

PVince81 reviewed Dec 9, 2014
View reviewed changes

lib/private/files/fileinfomanager.php

namespace OC\Files;

class FileInfoManager {

Copy link

Contributor

PVince81 Dec 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check whether it's still needed ?

This was referenced Dec 11, 2014

Ensure user mountpoints are setup when using getUserFolder #12786

Merged

Filesystem Public API and documentation quirks #12838

Closed

BernhardPosselt reviewed Dec 15, 2014
View reviewed changes

icewind1991 force-pushed the filesystem-factory branch from b3265aa to 7eefd65 Compare February 20, 2015 15:40

LukasReschke changed the title ~~Cleanup filesystem setup code~~ [WIP] Cleanup filesystem setup code Feb 24, 2015

icewind1991 referenced this pull request Mar 18, 2015

fix keystorage and add unit tests

429cab1

icewind1991 added 3 commits March 18, 2015 16:27

Cleanup filesystem setup code

e20879f

Dont create users in the database

c461e32

inject mount provider

3187cfe

icewind1991 force-pushed the filesystem-factory branch from 7eefd65 to 3187cfe Compare March 18, 2015 15:30

RobinMcCorkell mentioned this pull request Mar 18, 2015

[WIP] Use exceptions in SFTP backend #13390

Closed

PVince81 mentioned this pull request Jun 29, 2015

Missing OCP replacement for \OC_Util::setupFS() #17196

Closed

PVince81 added the comp:filesystem label Nov 20, 2015

icewind1991 closed this Nov 23, 2015

MorrisJobke deleted the filesystem-factory branch November 23, 2015 13:07

lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Cleanup filesystem setup code #11091

[WIP] Cleanup filesystem setup code #11091

icewind1991 commented Sep 15, 2014

RobinMcCorkell commented Sep 20, 2014

PVince81 commented Oct 31, 2014

icewind1991 commented Oct 31, 2014

PVince81 commented Oct 31, 2014

icewind1991 commented Oct 31, 2014

butonic commented Nov 11, 2014

icewind1991 commented Nov 11, 2014

PVince81 commented Nov 26, 2014

PVince81 Dec 9, 2014

PVince81 Dec 9, 2014

PVince81 Dec 9, 2014

BernhardPosselt Dec 15, 2014

PVince81 commented Jul 3, 2015

PVince81 commented Sep 1, 2015

icewind1991 commented Sep 1, 2015

MorrisJobke commented Nov 23, 2015

icewind1991 commented Nov 23, 2015

[WIP] Cleanup filesystem setup code #11091

[WIP] Cleanup filesystem setup code #11091

Conversation

icewind1991 commented Sep 15, 2014

RobinMcCorkell commented Sep 20, 2014

PVince81 commented Oct 31, 2014

icewind1991 commented Oct 31, 2014

PVince81 commented Oct 31, 2014

icewind1991 commented Oct 31, 2014

butonic commented Nov 11, 2014

icewind1991 commented Nov 11, 2014

PVince81 commented Nov 26, 2014

PVince81 Dec 9, 2014

Choose a reason for hiding this comment

PVince81 Dec 9, 2014

Choose a reason for hiding this comment

PVince81 Dec 9, 2014

Choose a reason for hiding this comment

BernhardPosselt Dec 15, 2014

Choose a reason for hiding this comment

PVince81 commented Jul 3, 2015

PVince81 commented Sep 1, 2015

icewind1991 commented Sep 1, 2015

MorrisJobke commented Nov 23, 2015

icewind1991 commented Nov 23, 2015