[WIP] Stream download for DAV exteral storage #10620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Does this support fseek ? If not, we need to be careful with range requests because our Sabre version doesn't fallback gracefully. |
|
I don't think so |
|
Also encryption has a fallback when fseek doesn't work, so better test that as well. Test plan for WebDAV ext storage:
|
| if ($this->certPath) { | ||
| curl_setopt($curl, CURLOPT_CAINFO, $this->certPath); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please explain why you have removed the above lines.
LukasReschke
changed the title
|
@icewind1991 do we want to revive this for 8.2 ? |
|
@Xenopathic @icewind1991 Revive or kill? |
|
revive |
Are you already reviving? ;) |
|
Superseeded by #18653 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents having to first download files from DAV to a temporary stream
cc @PVince81 @DeepDiver1975 @lokeller