Fix S3 copy and rename overwriting target directory #10104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Test Passed. 🚀 |
| @@ -52,7 +52,7 @@ class AmazonS3 extends \OC\Files\Storage\Common { | |||
| /** | |||
| * @var int | |||
| */ | |||
| private $timeout = 15; | |||
| private $timeout = 1; | |||
There was a problem hiding this comment.
Is there a reason that it defaults to 15 in the constructor below (https://github.com/owncloud/core/pull/10104/files#diff-440d6acd86f4ca1cb35ebcdaaaed8e54R93) but it was changed to 1 here?
There was a problem hiding this comment.
Changed it during debuging, reverted the change
icewind1991
force-pushed
the
s3-overwrite
branch
from
8d40be7 to
6d60630
Compare
|
A new inspection was created. |
|
🚀 Test Passed. 🚀 |
|
👍 |
|
👍 |
LukasReschke
added a commit
that referenced
this pull request
Oct 1, 2014
Fix S3 copy and rename overwriting target directory
|
Does this need a backport? |
|
yes, I'll do that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also skip a test for unsupported feature (mtime update of changed directory)
With this the unit tests for S3 pass for me locally.
cc @butonic @DeepDiver1975