-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files_external loads all users on admin page, which opens extremely slow with large user base #7499
Comments
Wow, I didn't realize that this app would do that. |
I had a quick look and it seems we're using the "chosen" library to display the list, which itself doesn't support ajax load and would require some trickery. |
The workaround is to disable files_external if it is not needed. |
@blizzz @PVince81 So far, the search box type feature sound the most promising. |
I have already worked with select2 and will have a look. |
@butonic |
@DeepDiver1975 pointed me to https://github.com/owncloud/core/tree/user-jquery where an ajaxified version of the user management happens. I am preparing a PR for the files_external app, based on current master. We only need the filter of the userlist anyway. |
Can we get someone to review this fix so we can get it in 6.0.4. |
I don't have an LDAP large enough to reproduce the issue. It was originally reported by @blizzz |
@ser72 I think you don't necessarily need to reproduce the slowness issue, but just test whether the PR works with many pages of users (like 200-300 users and many groups) and doesn't omit any. The PR makes the results paginated in some way. I just tried it and the result set is messy, so that will need fixing first (see my PR comment) |
…tion for files_external, fixes #7499
Moving to 7.0.1 |
The core issue that makes this one hard is that the results from the server are NOT sorted. I'm not sure it's worth to spend time to try working this around with JS because it will still be unusable. @blizzz is it possible to get sorted results from LDAP, assuming that we only use a single user backend ? (I understand that sorting + pagination is not possible with multiple backends). |
@blizzz Any updates here |
@blizzz |
No, unfortunately not. Only without Paged Search, but this is not an option for various reasons. |
@ser72 i need to continue work on it, however I have fixed deadlines for other things atm. |
A user tried oC7 and said it is much faster to load the admin page. Has this fix been placed into oC7? |
no |
Another idea: how about using the exact same mechanism like the share dropdown ? |
I had the same thought once upon a time, but why did i not follow it? Because it makes absolutely sense. And not only here but also when it is about picking groups only, e.g. in the apps when limiting access. |
@butonic This would be awesome |
…tion for files_external, fixes #7499 remove minified select2 js show avatars for users, simpler results remove unneeded users and groups from settings template fix css, escape user and group names
…tion for files_external, fixes #7499
…tion for files_external, fixes #7499 remove minified select2 js show avatars for users, simpler results remove unneeded users and groups from settings template fix css, escape user and group names
…tion for files_external, fixes #7499 remove minified select2 js show avatars for users, simpler results remove unneeded users and groups from settings template fix css, escape user and group names
@butonic |
…tion for files_external, fixes #7499
Steps to reproduce
Expected behaviour
Admin page opens quickly
Actual behaviour
Admin page takes long to load, because all users are fetched
Quick fix: load users via Ajax. Open admin page immediately, only files_external configuration will take longer until it is ready
Better fix: as above, but do a server side search if users and groups like the sharing box does.
Server configuration
ownCloud version: (see ownCloud admin page)
stable6, most likely master too
The text was updated successfully, but these errors were encountered: