Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Use chunks of 999 when preload directory content #29416

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Nov 2, 2017

Backport of #29405

Description

Use chunks of 999 when preload directory content

Related Issue

#29233

Motivation and Context

999 placeholder limit in Sqlite/Oracle

How Has This Been Tested?

With a unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the development milestone Nov 2, 2017
@VicDeo VicDeo self-assigned this Nov 2, 2017
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #29416 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #29416      +/-   ##
==============================================
+ Coverage        59.3%    59.3%   +<.01%     
- Complexity      17730    17735       +5     
==============================================
  Files            1061     1061              
  Lines           59429    59438       +9     
==============================================
+ Hits            35242    35251       +9     
  Misses          24187    24187
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/DAV/FileCustomPropertiesBackend.php 91.86% <100%> (+0.95%) 23 <4> (+5) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d1661...9cace53. Read the comment docs.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants