Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

10.0.4 release notes draft #3533

Merged
merged 11 commits into from
Nov 28, 2017
Merged

10.0.4 release notes draft #3533

merged 11 commits into from
Nov 28, 2017

Conversation

pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Nov 14, 2017

Draft for 10.0.4 release notes.

  • Still need input on some points (e.g. the Amazon v3 deprecation and some more. Please check the changes!)
  • Need to add doc links at some points
  • We might want to add known issues

@settermjd might want to help with formatting (looks a little strange right now :) ).

@PVince81 @tomneedham

The option "Restrict users to only share with users in their groups" in the admin sharing settings forces users to only be able to share with groups they are member of while simultaneously prohibiting to share with single users that do not belong to any of the users' groups. To make this more granular we split this option into two and added "Restrict users to only share with groups they are member of" which now differentiates between users and groups making it possible to force users to be able to share with all users of an installation but only with groups they are member of and vice versa. Please check if the new possibilities better suit your needs.

- **Configurable solution for indistinguishable user display names**
In the ownCloud sharing dialog users are displayed according to their display name. As users can choose their display name in self-service (can be disabled in config.php) and display names are not unique it is possible that a user can't distinguish sharing results. To cover this case the displayed user identifiers are now configurable. Administrators can configure to additionally display mail addresses or user ids. Please check if this new feature better suits your needs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this new feature better suits your needs.

Same comment as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to what? Added a note that admins find the new setting in sharing settings.

Same comment as above

This is a completely new feature that might be of interest to check for administrators.

- **All amazon locations support v4 now - v3 deprecated**
Need input on relevance of deprecation for existing external storages and on description of this item @tomneedham

- **Modified time value of files is now 64 bits long**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mtime = modification time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All amazon locations --> **All Amazon locations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

**It is recommended to configure CRON to execute this background job regularly (it is not included in the regular ownCloud background jobs to give administrators more flexibility in scheduling)**. Please check the ownCloud documentation for more information. **LINK (https://github.com/owncloud/documentation/pull/3522)**

- **Administrators can now exclude files from integrity check in config.php**
When administrators did intentional changes to the ownCloud code they now have the ability to exclude certain files from the integrity checker.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AKA how to shoot yourself in the foot ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now that you mention it I'm not 100% that it works that way.

the original purpose was to exclude non-OC files (often server specific hidden files) that people have lying around inside the OC folder.

need to test whether excluding already signed files from integrity check works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to @PVince81
would not state this as the reason for having that implemented which is different to this text.
(Do not open Pandoras Box...)
Please see the link to get an impression of: https://github.com/owncloud/core/pull/29126/files
Please reference to the documentation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this with the 10.0.4RC1 tarball and can confirm that you can exclude patched files from integrity check as well as any new file that you might have created. So the description is good.

Need input on relevance of deprecation for existing external storages and on description of this item @tomneedham

- **Modified time value of files is now 64 bits long**
Note: When upgrading to 10.0.4 migrations may increase update duration dependent on number of files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't this be done without downtime ... we really should think about a strategy for doing this ... probably with a new table that gets renamed after the column has been changed ... this will take hours on large installations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the right place to ask

Note: When upgrading to 10.0.4 migrations may increase update duration dependent on number of files.

- **Updated minimum supported browser versions**
Note: Users with outdated browsers might get warnings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exact versions are?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable10 PR owncloud/core#29507

-		vs: { i: 10, f: 45, o: 0, s: 8, c: 45 },
+		vs: { i: 10, f: 54, o: 0, s: 9, c: 60 },

those are the max unsupported version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc update PR #3505

+- Edge (current version on Windows 10)
 - IE11+ (except Compatibility Mode)
-- Firefox 14+
-- Chrome 18+
-- Safari 5+
+- Firefox 55+ or 52 ESR
+- Chrome 61+
+- Safari 10+
 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the documetation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, link added.

Changes in 10.0.4
-----------------

Dear ownCloud administrator, please find below the changes and known issues of ownCloud Server 10.0.4 that need your attention:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "known issues in ownCloud Server" instead of "known issues of ownCloud Server"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

**The full ownCloud Server 10.0.4 changelog can be found here: https://github.com/owncloud/core/blob/stable10/CHANGELOG.md**

* **More granular sharing restrictions**
The option "Restrict users to only share with users in their groups" in the admin sharing settings forces users to only be able to share with groups they are member of while simultaneously prohibiting to share with single users that do not belong to any of the users' groups. To make this more granular we split this option into two and added "Restrict users to only share with groups they are member of" which now differentiates between users and groups making it possible to force users to be able to share with all users of an installation but only with groups they are member of and vice versa. Please check if the new possibilities better suit your needs.
Copy link
Contributor

@settermjd settermjd Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following?


The "Restrict users to only share with users in their groups" option, in the admin sharing settings, restricts users to only share with groups which they are a member of, while simultaneously prohibiting sharing with single users that do not belong to any of the users' groups.

To make this more granular, we split this option into two parts and added "Restrict users to only share with groups they are a member of", which differentiates between users and groups. Doing so makes it possible to restrict users from sharing with all users of an installation, limiting them to only being able to share with groups which they are a member of, and vice versa.

Please check if the new possibilities better suit your needs.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the text on the UI says "...they are member of"
one day, maybe, that could be changed to say "...they are a member of"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if the new possibilities better suit your needs.

Is imho not necessary, as the old way still exists and the new implementation is an addition

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, changed. as @phil-davis said the option is called like this in the UI..

The option "Restrict users to only share with users in their groups" in the admin sharing settings forces users to only be able to share with groups they are member of while simultaneously prohibiting to share with single users that do not belong to any of the users' groups. To make this more granular we split this option into two and added "Restrict users to only share with groups they are member of" which now differentiates between users and groups making it possible to force users to be able to share with all users of an installation but only with groups they are member of and vice versa. Please check if the new possibilities better suit your needs.

- **Configurable solution for indistinguishable user display names**
In the ownCloud sharing dialog users are displayed according to their display name. As users can choose their display name in self-service (can be disabled in config.php) and display names are not unique it is possible that a user can't distinguish sharing results. To cover this case the displayed user identifiers are now configurable. Administrators can configure to additionally display mail addresses or user ids. Please check if this new feature better suits your needs.
Copy link
Contributor

@settermjd settermjd Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the following:


The ownCloud sharing dialog displays users according to their display name. As users can choose their display name in self-service (which can be disabled in config.php) and display names are not unique, it is possible that a user can't distinguish sharing results. To cover this case the displayed user identifiers are now configurable. Administrators can now configure the display of either mail addresses or user ids. Please check if this new feature better suits your needs.


@tomneedham
Copy link
Contributor

Fix bug when viewing folder with > 1000 files in owncloud/core#29416

@tomneedham
Copy link
Contributor

Amazon v3 signature is already depreceated in some of their regions. We updated our usage to always use v4 signature, which is now supported at all regions

@PVince81
Copy link
Contributor

Note: the release notes are not the same as changelog. General bugfixes belong in the changelog.

Release notes are entries worthy of getting admin's attention:

  • things that might motivate an admin to upgrade
  • things that might prevent an admin to upgrade (known issues with some systems that might be in use)
  • things that need attention and action after an update (ex: must setup a new cron)


- **Added "occ files:scan" repair mode to repair filecache inconsistencies**
We recommend to use this command when directed to do so in the upgrade process (TODO more info)
Please check the ownCloud documentation for more information. **LINK (https://github.com/owncloud/documentation/issues/3446)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest directly integrating the link:

Please check the ownCloud documentation for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a placeholder for the correct doc link. I actually don't want to link to a ticket/PR.

Please check the ownCloud documentation for more information. **LINK (https://github.com/owncloud/documentation/issues/3446)**

- **Detailed mode for "occ security:routes"**
Administrators can use the output of this command when using a network firewall to check the appropriateness of configured rules or to get assistance when setting up.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a little more punctuation, e.g.,

"Administrators can use the output of this command when using a network firewall, to check the appropriateness of configured rules or to get assistance when setting up."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when setting up --> when setting it up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

Administrators can use the output of this command when using a network firewall to check the appropriateness of configured rules or to get assistance when setting up.

- **Added mode of operations to differentiate between single-instance or clustered setup**
As ownCloud needs to behave differently when operating in a clustered setup we added a config.php option ``'operation.mode' => 'single-instance' or 'clustered-instance'``.
Copy link
Contributor

@settermjd settermjd Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For utmost clarity, I'd write this a little differently:


As ownCloud needs to behave differently when operating in a clustered setup to a single instance setup, we added a new config.php option operation.mode. It can take one of two values: single-instance and clustered-instance.
For example:

'operation.mode' => 'single-instance',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clustered setup to a single instance setup --> clustered setup versus a single instance setup

we added a new config.php option operation.mode --> a new config.php option operation.mode has been added

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

As ownCloud needs to behave differently when operating in a clustered setup we added a config.php option ``'operation.mode' => 'single-instance' or 'clustered-instance'``.
Currently the Market App (ownCloud Marketplace integration) does not support clustered setups and can do harm when used for installing or updating apps. The new config setting prevents this and other actions that are undesired in cluster mode.
**Therefore when operating in a clustered setup it is mandatory to set this option.**
Please check the ownCloud documentation for more information. **LINK (https://github.com/owncloud/documentation/pull/3506)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, enable the link directly in the text:


Please check the ownCloud documentation for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a placeholder for the correct doc link. I actually don't want to link to a ticket/PR.

Please check the ownCloud documentation for more information. **LINK (https://github.com/owncloud/documentation/pull/3506)**

- **Added occ dav:cleanup-chunks command to clean up expired uploads**
When file uploads are interrupted by any reason already uploaded file parts (chunks) stay on the storage to be able to resume the file upload in a following upload run. Resuming an upload is only possible until the partial upload is expired and deleted, respectively. To cleanup chunks (expire and delete) originating from unfinished uploads administrators can use this newly introduced command. The expiry time default is two days but can be specified as a parameter of this command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest some minor changes, as below:


When file uploads are interrupted for any reason, already uploaded file parts (chunks) remain in the underlying storage so that the file upload can resume in a future upload attempt.

However, resuming an upload is only possible until the partial upload is either expired or deleted. To clean up chunks (expire and delete) originating from unfinished uploads, administrators can use this newly introduced command. The expiry time default is two days, but it can be specified as a parameter to the command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expiry time default is two days --> The default expiry time is two days, but can be specified as an additional parameter to this command.

Pls reference to the documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. No doc available.


- **Added occ dav:cleanup-chunks command to clean up expired uploads**
When file uploads are interrupted by any reason already uploaded file parts (chunks) stay on the storage to be able to resume the file upload in a following upload run. Resuming an upload is only possible until the partial upload is expired and deleted, respectively. To cleanup chunks (expire and delete) originating from unfinished uploads administrators can use this newly introduced command. The expiry time default is two days but can be specified as a parameter of this command.
**It is recommended to configure CRON to execute this background job regularly (it is not included in the regular ownCloud background jobs to give administrators more flexibility in scheduling)**. Please check the ownCloud documentation for more information. **LINK (https://github.com/owncloud/documentation/pull/3522)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above, enable the link directly in the text:


It is recommended to configure Cron to execute this background job regularly. It is not included in the regular ownCloud background jobs so that the administrators have more flexibility in scheduling it. Please check the ownCloud documentation for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cron --> CRON (preferred) or cron

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

Copy link
Contributor

@settermjd settermjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the suggested changes, the file seems fine to me.

@pmaier1
Copy link
Contributor Author

pmaier1 commented Nov 15, 2017

Thanks for feedback. Incorporated suggested changes.

Amazon v3 signature is already depreceated in some of their regions. We updated our usage to always use v4 signature, which is now supported at all regions

This does not help me. Please tell me if this is relevant in the release notes and what exactly needs to be addressed by an admin.

settermjd
settermjd previously approved these changes Nov 15, 2017
Add doc link for occ dav:cleanup-chunks
@pmaier1
Copy link
Contributor Author

pmaier1 commented Nov 15, 2017

Don't merge yet:

  • Doc link missing for "Added "occ files:scan" repair mode to repair filecache inconsistencies" (not yet merged)
  • The known issues list is empty which is a good thing of course. Please add if there is something.

@mmattel
Copy link
Contributor

mmattel commented Nov 16, 2017

Merged: owncloud/core#28253 (Add repair step to repair mismatch filecache paths)
Open: owncloud/core#29581 (Update the help output for the occ files:scan command)

@settermjd
Copy link
Contributor

@pmaier1 is this ready to merge?

@pmaier1
Copy link
Contributor Author

pmaier1 commented Nov 22, 2017

  • Added doc link for occ files:scan repair mode
  • Added hint that there are no known issues (I want to prevent people wondering if we missed to mention it in the release notes)

Open: owncloud/core#29581 (Update the help output for the occ files:scan command)

@mmattel You mention in the PR that this would be important for the release notes. I don't see the relation. Can you explain?

Apart from this I think we're good here. Anyway, I would wait for the release to merge and publish it.

@mmattel
Copy link
Contributor

mmattel commented Nov 24, 2017

I only added in the referenced open core PR that it would be good to have that one also being ready before 10.0.4 gets released to have things proper and clean documented. The text text provided here is fine to me 👍

@settermjd
Copy link
Contributor

So, it's ready to be merged?


**Known issues**

Currently there are no known issues for ownCloud Server 10.0.4.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this section ? This seems to state that ownCloud 10.0.4 is bug-free which is not correct 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As no software's bug-free, I'd say yes.

Copy link
Contributor Author

@pmaier1 pmaier1 Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said above I left the section not to confuse people that we might have missed to add it. This way it states that there are no issues that we consider as "known" and "to-be-fixed". Should we remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'd leave it. It's clear in what it says, and it's honest.

Note: Users with outdated browsers might get warnings. See the list of supported browser versions: https://doc.owncloud.com/server/10.0/admin_manual/installation/system_requirements.html#web-browser

- **10.0.3 known issues are solved**
- SFTP external storages with key pair mode work again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add links to resolved tickets ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It's great for transparency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@mmattel
Copy link
Contributor

mmattel commented Nov 27, 2017

@PVince81 should a note be added that owncloud/core#29261 (Remove double quotes from boolean values in status.php output) has been solved ?

@PVince81
Copy link
Contributor

@PVince81 should a note be added that owncloud/core#29261 (Remove double quotes from boolean values in status.php output) has been solved ?

Considering that it was a known issue in 10.0.3 it might make sense to mention that it's fixed now, yes.

@pmaier1
Copy link
Contributor Author

pmaier1 commented Nov 28, 2017

@PVince81 should a note be added that owncloud/core#29261 (Remove double quotes from boolean values in status.php output) has been solved ?

Added.

@PVince81
Copy link
Contributor

Ok I only see thumbs up everywhere, so it seems this is ready for merge then ?

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit c6e623e into master Nov 28, 2017
@PVince81 PVince81 deleted the pmaier1-patch-2 branch November 28, 2017 09:40
@PVince81
Copy link
Contributor

@settermjd does this need a backport to become visible ? If yes, can you take care ? Thanks

@settermjd
Copy link
Contributor

On it now.

@settermjd
Copy link
Contributor

Done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants