Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don´t change folders with --repair-filecache #27668

Merged
merged 1 commit into from
May 4, 2017
Merged

don´t change folders with --repair-filecache #27668

merged 1 commit into from
May 4, 2017

Conversation

Rello
Copy link
Contributor

@Rello Rello commented Apr 18, 2017

Description

check if folder is "httpd/unix-directory" and don´t perform --repair-filecache there

Related Issue

Motivation and Context

How Has This Been Tested?

WAV folder is not changed anymore

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

check if folder is "httpd/unix-directory" and don´t perform here #27585
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2017

CLA assistant check
All committers have signed the CLA.

@PVince81
Copy link
Contributor

PVince81 commented May 4, 2017

👍 thanks

@PVince81 PVince81 merged commit 0b3966e into owncloud:master May 4, 2017
@PVince81
Copy link
Contributor

PVince81 commented Jul 6, 2017

Turns out that having the wrong mime type for folders can be dangerous when doing MOVE operations, as the MOVE would not move the child entries since it believes the main entry is not a folder.

Let's backport this down to stable9.

cc @tomneedham @jvillafanez

@PVince81
Copy link
Contributor

PVince81 commented Jul 6, 2017

stable9.1: #28326
stable9: #28327

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants