mimetype:update-db changes a folder to "audio/*"

[Rello]

Steps to reproduce

1. create a folder "WAV"
2. check filecache: mimetype 1 (unix directory)
3. execute occ maintenance:mimetype:update-db --repair-filecache
4. check filecache: mimetype "audio/wav"

Expected behaviour

nothing bad

Actual behaviour

a folder becomes an audio file

Server configuration

Operating system:
Debian
Web server:
nginx
Database:
mariadb
PHP version:
7.0
ownCloud version: (see ownCloud admin page)
9.1.4

[PVince81]

I guess the mimetype code needs to first verify whether the target is actually a file.

@Rello do you have time to dig into this ?

[Rello]

@PVince81 I think I this is the related part

core/lib/private/Files/Type/Loader.php

Lines 160 to 169 in f10d105

	public function updateFilecache($ext, $mimetypeId) {
	$update = $this->dbConnection->getQueryBuilder();
	$update->update('filecache')
	->set('mimetype', $update->createNamedParameter($mimetypeId))
	->where($update->expr()->neq(
	'mimetype', $update->createNamedParameter($mimetypeId)
	))
	->andWhere($update->expr()->like(
	$update->createFunction('LOWER(`name`)'), $update->createNamedParameter($ext)
	));

it does a plain find by like LOWER(name) and there, even a folder /WAV will be changed.
how to approach this?
by excluding folders in general you don´t have the possibility to change the global folder-mime-type anymore. but compared to this issue, this should be neglected.

do you agree?

the simplest solution would be to exclude the mimetype completely from processing
"httpd/unix-directory": "dir",

[PVince81]

Excluding the directory mimetype in that query sounds like a good plan.

[Rello]

I will create a pull

[PVince81]

thanks a lot!

[ownclouders]

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

[PVince81]

this was fixed through #27668

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.