Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing S3 unit tests on master / cannot create folder on S3 #11725

Closed
PVince81 opened this issue Oct 22, 2014 · 1 comment · Fixed by #11726
Closed

Failing S3 unit tests on master / cannot create folder on S3 #11725

PVince81 opened this issue Oct 22, 2014 · 1 comment · Fixed by #11726

Comments

@PVince81
Copy link
Contributor

S3 unit tests fail on master 993376f
But they run fine on stable7 6995b96

(these are the commits before the regression I introduced here #11714)

Still, wondering why the tests fail on master when the files are identical.
I suspect it might be related to the upgrade to the new version.

Many tests fail with the same error and stack trace:

Aws\Common\Exception\InvalidArgumentException: You must specify a non-null value for the Body or SourceFile parameters.

/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Aws/Common/Client/UploadBodyListener.php:91
/srv/www/htdocs/owncloud/3rdparty/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php:164
/srv/www/htdocs/owncloud/3rdparty/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php:53
/srv/www/htdocs/owncloud/3rdparty/guzzle/common/Guzzle/Common/AbstractHasDispatcher.php:40
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Guzzle/Service/Command/AbstractCommand.php:233
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Guzzle/Service/Client.php:205
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Guzzle/Service/Client.php:136
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Guzzle/Service/Command/AbstractCommand.php:153
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Guzzle/Service/Command/AbstractCommand.php:189
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Guzzle/Service/Client.php:76
/srv/www/htdocs/owncloud/apps/files_external/3rdparty/aws-sdk-php/Aws/Common/Client/AbstractClient.php:108
/srv/www/htdocs/owncloud/apps/files_external/lib/amazons3.php:188
/srv/www/htdocs/owncloud/apps/files_external/lib/amazons3.php:188
/srv/www/htdocs/owncloud/tests/lib/files/storage/storage.php:521

It seems to be related to directory creation.
Do we need to pass a body when creating folders ?!

@butonic @helmutschneider any clue ?

@PVince81 PVince81 added this to the 2014-sprint-06-current milestone Oct 22, 2014
@PVince81
Copy link
Contributor Author

Note: we'll try and setup CI soon for external storage to catch such errors in the future (#11717)

Until now we need to run the unit tests locally...

@PVince81 PVince81 changed the title Failing S3 unit tests on master Failing S3 unit tests on master / cannot create folder on S3 Oct 22, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant