Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] Exclude group from shares dropdown broken #10936

Closed
PVince81 opened this issue Sep 8, 2014 · 7 comments · Fixed by #10968
Closed

[stable7] Exclude group from shares dropdown broken #10936

PVince81 opened this issue Sep 8, 2014 · 7 comments · Fixed by #10968

Comments

@PVince81
Copy link
Contributor

PVince81 commented Sep 8, 2014

Steps to reproduce

  1. Create a group in the users page
  2. Open admin page
  3. Scroll down to "Exclude groups from sharing"
  4. Tick checkbox
  5. Open dropdown

Expected result

Dropdown opens

Actual result

Dropdown does not open.

Versions

Works in OC 7.0.2 but broken on stable7.

I've bisected this and it comes down to this commit from @jancborchardt 30cc4b9

It is very strange how a simple overflow can mess up multiselect.

I'll try and find a compatible solution for multiselect.

@PVince81 PVince81 added this to the 2014-sprint-04-next milestone Sep 8, 2014
@PVince81
Copy link
Contributor Author

PVince81 commented Sep 8, 2014

@MTRichards @craigpg set to next sprint, sev2-high as it makes it impossible to use the "exclude sharing from groups feature".

Note: this is only on stable7 so it must be fixed for OC 7.0.3.

@PVince81
Copy link
Contributor Author

PVince81 commented Sep 8, 2014

I noticed that if you delete the previous admin sections to make the multiselect appear on the first page (without scrolling), then the multiselect works correctly.
Possibly something broken in its offset calculation.

@jancborchardt
Copy link
Member

Ugh - that's indeed strange. Sorry it didn't come up during testing. We definitely need the overflow so that the external storage and network drive functions are usable.

Thanks for looking into fixing multiselect. Cc @icewind1991 cause he wrote multiselect.js

@MTRichards
Copy link
Contributor

Ok, thanks @PVince81

@MTRichards MTRichards modified the milestones: 2014-sprint-03-current, 2014-sprint-04-next Sep 8, 2014
@MTRichards
Copy link
Contributor

I noticed this too, by the way. Had this problem last week with the Sept 4 daily stable 7 build.

@craigpg
Copy link

craigpg commented Sep 17, 2014

@PVince81... making this a gold-ticket

@PVince81
Copy link
Contributor Author

The fix is already here: #10968

@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants