Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin page pulls in all groups at once, can cause long loading time #9014

Closed
blizzz opened this issue Jun 12, 2014 · 10 comments
Closed

admin page pulls in all groups at once, can cause long loading time #9014

blizzz opened this issue Jun 12, 2014 · 10 comments

Comments

@blizzz
Copy link
Contributor

blizzz commented Jun 12, 2014

By https://github.com/owncloud/core/blob/master/settings/admin.php#L55 all groups are loaded. On bigger LDAP setups (my test setup here > 7k groups) this will lead to long loading times.

To reproduce:

  1. create a huge amount of groups (preferably with LDAP)
  2. open admin page

cc @schiesbn

@MTRichards MTRichards added this to the ownCloud 7.0.1 milestone Jun 20, 2014
@PVince81
Copy link
Contributor

This should probably be fixed by #8507 ?

@craigpg craigpg modified the milestones: 2014-sprint-03-next, 2014-sprint-02-current Sep 2, 2014
@craigpg
Copy link

craigpg commented Sep 4, 2014

@blizz, can you confirm that this is fixed by #8507?

@blizzz
Copy link
Contributor Author

blizzz commented Sep 5, 2014

@craigpg it is fixed in master, needs to be backported

@karlitschek
Copy link
Contributor

@blizzz would be good if you could do that

@blizzz
Copy link
Contributor Author

blizzz commented Sep 5, 2014

Just have seen, @butonic did already do a backport to 7 #10558 which was merged.
And also to 6 which is yet open #10576

@butonic butonic self-assigned this Sep 8, 2014
@PVince81
Copy link
Contributor

PVince81 commented Sep 9, 2014

Note: groups will be pulled as well for the "exclude sharing from groups", so that part needs to be fixed as well.

@PVince81
Copy link
Contributor

PVince81 commented Sep 9, 2014

Another idea is to just use select2 with ajax like it was done here #10558
Might fix #10936 .

I'll give it a try as part of #10936

@craigpg craigpg modified the milestones: 2014-sprint-04-current, 2014-sprint-03, 2014-sprint-05-next Sep 15, 2014
@craigpg craigpg modified the milestones: 2014-sprint-06-next, 2014-sprint-05-current Sep 29, 2014
@butonic
Copy link
Member

butonic commented Oct 10, 2014

@blizzz @PVince81 I assume this can be closed?

@blizzz
Copy link
Contributor Author

blizzz commented Oct 10, 2014

backport to stable6 is yet open #10576

@craigpg craigpg modified the milestones: 2014-sprint-07-next, 2014-sprint-06-current Oct 12, 2014
@craigpg craigpg modified the milestones: 2014-sprint-08-next, 2014-sprint-07-current Oct 27, 2014
@craigpg craigpg modified the milestones: 2014-sprint-09-next, 2014-sprint-08-current Nov 10, 2014
@blizzz
Copy link
Contributor Author

blizzz commented Nov 26, 2014

Issue fixed.

@blizzz blizzz closed this as completed Nov 26, 2014
@DeepDiver1975 DeepDiver1975 modified the milestones: 2014-sprint-09-next, 8.1-next Jan 9, 2015
@MorrisJobke MorrisJobke modified the milestones: 8.0-current, 8.1-next Jan 14, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants