Skip to content

Commit

Permalink
Merge pull request #34987 from owncloud/fix-gdrive
Browse files Browse the repository at this point in the history
[stable10] fix multi gdrive external storage bug
  • Loading branch information
Vincent Petry authored Apr 12, 2019
2 parents d517d59 + 3a01edd commit faff8f3
Showing 1 changed file with 28 additions and 29 deletions.
57 changes: 28 additions & 29 deletions apps/files_external/js/gdrive.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,38 +22,37 @@ $(document).ready(function() {
});
el.tooltip({placement: 'top'});
backendEl.append(el);
}
});

/**
* ------- OAUTH2 Events ----------
*
* The files_external_{backendId} app's CUSTOM JS should handle the OAuth2 events itself
* instead on relying on the core for the implemention. These two functions
* [1] OCA.External.Settings.OAuth2.getAuthUrl, [2] OCA.External.Settings.OAuth2.verifyCode
* abstract away the details of sending the request to backend for getting the AuthURL or
* verifying the code, mounting the storage config etc
*/
$('.configuration').on('oauth_step1', function (event, data) {
if (data['backend_id'] !== backendId) {
return; // means the trigger is not for this storage adapter
}
/**
* ------- OAUTH2 Events ----------
*
* The files_external_{backendId} app's CUSTOM JS should handle the OAuth2 events itself
* instead on relying on the core for the implemention. These two functions
* [1] OCA.External.Settings.OAuth2.getAuthUrl, [2] OCA.External.Settings.OAuth2.verifyCode
* abstract away the details of sending the request to backend for getting the AuthURL or
* verifying the code, mounting the storage config etc
*/
$tr.find('.configuration').on('oauth_step1', function (event, data) {
if (data['backend_id'] !== backendId) {
return; // means the trigger is not for this storage adapter
}

// Redirects the User on success else displays an alert (with error message sent by backend)
OCA.External.Settings.OAuth2.getAuthUrl(backendUrl, data);
});
// Redirects the User on success else displays an alert (with error message sent by backend)
OCA.External.Settings.OAuth2.getAuthUrl(backendUrl, data);
});

$('.configuration').on('oauth_step2', function (event, data) {
if (data['backend_id'] !== backendId || data['code'] === undefined) {
return; // means the trigger is not for this OAuth2 grant
}
$tr.find('.configuration').on('oauth_step2', function (event, data) {
if (data['backend_id'] !== backendId || data['code'] === undefined) {
return; // means the trigger is not for this OAuth2 grant
}

OCA.External.Settings.OAuth2.verifyCode(backendUrl, data)
.fail(function (message) {
OC.dialogs.alert(message,
t('files_external', 'Error verifying OAuth2 Code for ' + backendId)
);
})
OCA.External.Settings.OAuth2.verifyCode(backendUrl, data)
.fail(function (message) {
OC.dialogs.alert(message,
t('files_external', 'Error verifying OAuth2 Code for ' + backendId)
);
});
});
}
});

});

0 comments on commit faff8f3

Please sign in to comment.