Merge pull request #33410 from owncloud/stable10-remove-skip-on-fixed…

…Issues [stable10] remove skip on fixed issues
owncloud · Nov 5, 2018 · f4f25e1 · f4f25e1
2 parents c3300cb + 1374ef4
commit f4f25e1
Show file tree

Hide file tree

Showing 19 changed files with 85 additions and 68 deletions.
diff --git a/tests/acceptance/features/apiProvisioning-v2/addGroup.feature b/tests/acceptance/features/apiProvisioning-v2/addGroup.feature
@@ -75,12 +75,13 @@ Feature: add groups
     And the HTTP status code should be "400"
     And group "new-group" should exist
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to create a group
     Given user "brand-new-user" has been created
     When user "brand-new-user" sends HTTP method "POST" to OCS API endpoint "/cloud/groups" with body
       | groupid | new-group |
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And group "new-group" should not exist
 

diff --git a/tests/acceptance/features/apiProvisioning-v2/addToGroup.feature b/tests/acceptance/features/apiProvisioning-v2/addToGroup.feature
@@ -62,12 +62,13 @@ Feature: add users to group
       | var/../etc       | using slash-dot-dot                |
       | priv/subadmins/1 | Subadmins mentioned not at the end |
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to add himself to a group
     Given user "brand-new-user" has been created
     When user "brand-new-user" sends HTTP method "POST" to OCS API endpoint "/cloud/users/brand-new-user/groups" with body
       | groupid | new-group |
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the API should not return any data
 

diff --git a/tests/acceptance/features/apiProvisioning-v2/createSubAdmin.feature b/tests/acceptance/features/apiProvisioning-v2/createSubAdmin.feature
@@ -34,7 +34,7 @@ Feature: create a subadmin
     Then the OCS status code should be "400"
     And the HTTP status code should be "400"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin of a group tries to make another user subadmin of their group
     Given user "subadmin" has been created
     And user "brand-new-user" has been created
@@ -44,7 +44,8 @@ Feature: create a subadmin
       | groupid | new-group |
     When user "subadmin" sends HTTP method "POST" to OCS API endpoint "/cloud/users/brand-new-user/subadmins" with body
       | groupid | new-group |
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the user "not-user" should not be the subadmin of the group "new-group"
 
diff --git a/tests/acceptance/features/apiProvisioning-v2/deleteGroup.feature b/tests/acceptance/features/apiProvisioning-v2/deleteGroup.feature
@@ -59,22 +59,24 @@ Feature: delete groups
       | var/../etc       | using slash-dot-dot                |
       | priv/subadmins/1 | Subadmins mentioned not at the end |
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to delete the group
     Given user "brand-new-user" has been created
     And group "new-group" has been created
     And user "brand-new-user" has been added to group "new-group"
     When user "brand-new-user" sends HTTP method "DELETE" to OCS API endpoint "/cloud/groups/new-group"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And group "new-group" should exist
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin of the group tries to delete the group
     Given user "subadmin" has been created
     And group "new-group" has been created
     And user "subadmin" has been made a subadmin of group "new-group"
     When user "subamin" sends HTTP method "DELETE" to OCS API endpoint "/cloud/groups/new-group"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And group "new-group" should exist
diff --git a/tests/acceptance/features/apiProvisioning-v2/deleteUser.feature b/tests/acceptance/features/apiProvisioning-v2/deleteUser.feature
@@ -27,11 +27,12 @@ Feature: delete users
     And the HTTP status code should be "200"
     And user "brand-new-user" should not exist
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to delete a user
     Given user "user1" has been created
     And user "user2" has been created
     When user "user1" sends HTTP method "DELETE" to OCS API endpoint "/cloud/users/user2"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And user "user2" should exist
diff --git a/tests/acceptance/features/apiProvisioning-v2/disableApp.feature b/tests/acceptance/features/apiProvisioning-v2/disableApp.feature
@@ -15,22 +15,24 @@ Feature: disable an app
     And the HTTP status code should be "200"
     And app "comments" should be disabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin tries to disable an app
     Given user "subadmin" has been created
     And group "newgroup" has been created
     And user "subadmin" has been made a subadmin of group "newgroup"
     And the app "comments" has been enabled
     When user "subadmin" disables the app "comments"
     Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And app "comments" should be enabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to disable an app
     Given user "newuser" has been created
     And the app "comments" has been enabled
     When user "newuser" disables the app "comments"
     Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And app "comments" should be enabled
diff --git a/tests/acceptance/features/apiProvisioning-v2/disableUser.feature b/tests/acceptance/features/apiProvisioning-v2/disableUser.feature
@@ -28,7 +28,7 @@ Feature: disable user
     And the HTTP status code should be "200"
     And user "user1" should be disabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: Subadmin should not be able to disable an user not in their group
     Given user "subadmin" has been created
     And user "user1" has been created
@@ -38,11 +38,12 @@ Feature: disable user
     And user "user1" has been added to group "another-group"
     And user "subadmin" has been made a subadmin of group "new-group"
     When user "subadmin" sends HTTP method "PUT" to OCS API endpoint "/cloud/users/user1/disable"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And user "user1" should be enabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: Subadmins should not be able to disable users that have admin permissions in their group
     Given user "another-admin" has been created
     And user "subadmin" has been created
@@ -52,7 +53,8 @@ Feature: disable user
     And user "another-admin" has been added to group "new-group"
     And user "subadmin" has been made a subadmin of group "new-group"
     When user "subadmin" sends HTTP method "PUT" to OCS API endpoint "/cloud/users/another-admin/disable"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And user "another-admin" should be enabled
 
@@ -83,12 +85,13 @@ Feature: disable user
     And the HTTP status code should be "400"
     And user "another-admin" should be enabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: disable an user with a regular user
     Given user "user1" has been created
     And user "user2" has been created
     When user "user1" sends HTTP method "PUT" to OCS API endpoint "/cloud/users/user2/disable"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And user "user2" should be enabled
 

diff --git a/tests/acceptance/features/apiProvisioning-v2/enableApp.feature b/tests/acceptance/features/apiProvisioning-v2/enableApp.feature
@@ -15,22 +15,24 @@ Feature: enable an app
     And the HTTP status code should be "200"
     And app "comments" should be enabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin tries to enable an app
     Given user "subadmin" has been created
     And group "newgroup" has been created
     And user "subadmin" has been made a subadmin of group "newgroup"
     And the app "comments" has been disabled
     When user "subadmin" enables the app "comments"
     Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And app "comments" should be disabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to enable an app
     Given user "newuser" has been created
     And the app "comments" has been disabled
     When user "newuser" enables the app "comments"
     Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And app "comments" should be disabled
diff --git a/tests/acceptance/features/apiProvisioning-v2/enableUser.feature b/tests/acceptance/features/apiProvisioning-v2/enableUser.feature
@@ -44,13 +44,14 @@ Feature: enable user
     When user "another-admin" sends HTTP method "PUT" to OCS API endpoint "/cloud/users/another-admin/enable"
     Then user "another-admin" should be disabled
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to enable other user
     Given user "user1" has been created
     And user "user2" has been created
     And user "user2" has been disabled
     When user "user1" sends HTTP method "PUT" to OCS API endpoint "/cloud/users/user2/enable"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And user "user2" should be disabled
 

diff --git a/tests/acceptance/features/apiProvisioning-v2/getGroup.feature b/tests/acceptance/features/apiProvisioning-v2/getGroup.feature
@@ -44,20 +44,22 @@ Feature: get group
       | user1 |
       | user2 |
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin tries to get users in a group he is not responsible for
     Given user "subadmin" has been created
     And group "new-group" has been created
     And group "another-group" has been created
     And user "subadmin" has been made a subadmin of group "new-group"
     When user "subadmin" sends HTTP method "GET" to OCS API endpoint "/cloud/groups/another-group"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to get users in his group
     Given user "newuser" has been created
     And group "new-group" has been created
     When user "newuser" sends HTTP method "GET" to OCS API endpoint "/cloud/groups/new-group"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
diff --git a/tests/acceptance/features/apiProvisioning-v2/getSubAdmins.feature b/tests/acceptance/features/apiProvisioning-v2/getSubAdmins.feature
@@ -26,25 +26,27 @@ Feature: get subadmins
     And the HTTP status code should be "400"
     And the API should not return any data
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin tries to get other subadmins of the same group
     Given user "subadmin" has been created
     And user "newsubadmin" has been created
     And group "new-group" has been created
     And user "subadmin" has been made a subadmin of group "new-group"
     And user "newsubadmin" has been made a subadmin of group "new-group"
     When user "subadmin" sends HTTP method "GET" to OCS API endpoint "/cloud/groups/new-group/subadmins"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the API should not return any data
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to get the subadmins of the group
     Given user "newuser" has been created
     And user "subadmin" has been created
     And group "new-group" has been created
     And user "subadmin" has been made a subadmin of group "new-group"
     When user "newuser" sends HTTP method "GET" to OCS API endpoint "/cloud/groups/new-group/subadmins"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the API should not return any data
diff --git a/tests/acceptance/features/apiProvisioning-v2/getUserGroups.feature b/tests/acceptance/features/apiProvisioning-v2/getUserGroups.feature
@@ -80,13 +80,14 @@ Feature: get user groups
     And the OCS status code should be "200"
     And the HTTP status code should be "200"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to get the groups of another user
     Given user "newuser" has been created
     And user "anotheruser" has been created
     And group "newgroup" has been created
     And user "newuser" has been added to group "newgroup"
     When user "anotheruser" sends HTTP method "GET" to OCS API endpoint "/cloud/users/newuser/groups"
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the API should not return any data
diff --git a/tests/acceptance/features/apiProvisioning-v2/getUsers.feature b/tests/acceptance/features/apiProvisioning-v2/getUsers.feature
@@ -30,11 +30,12 @@ Feature: get users
     And the OCS status code should be "200"
     And the HTTP status code should be "200"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to get other users
     Given user "normaluser" has been created
     And user "newuser" has been created
     When user "normaluser" sends HTTP method "GET" to OCS API endpoint "/cloud/users"
-    And the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the API should not return any data
diff --git a/tests/acceptance/features/apiProvisioning-v2/removeFromGroup.feature b/tests/acceptance/features/apiProvisioning-v2/removeFromGroup.feature
@@ -103,7 +103,7 @@ Feature: remove a user from a group
     And the HTTP status code should be "403"
     And user "brand-new-user" should belong to group "new-group"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to remove the user in his group
     Given user "newuser" has been created
     And user "anotheruser" has been created
@@ -112,6 +112,7 @@ Feature: remove a user from a group
     And user "anotheruser" has been added to group "new-group"
     When user "newuser" sends HTTP method "DELETE" to OCS API endpoint "/cloud/users/anotheruser/groups" with body
       | groupid | new-group |
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And user "anotheruser" should belong to group "new-group"
diff --git a/tests/acceptance/features/apiProvisioning-v2/removeSubAdmin.feature b/tests/acceptance/features/apiProvisioning-v2/removeSubAdmin.feature
@@ -18,7 +18,7 @@ Feature: remove subadmin
     And the HTTP status code should be "200"
     And the user "brand-new-user" should not be the subadmin of the group "new-group"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: subadmin tries to remove other subadmin in the group
     Given user "subadmin" has been created
     And group "new-group" has been created
@@ -27,11 +27,12 @@ Feature: remove subadmin
     And user "newsubadmin" has been made a subadmin of group "new-group"
     When user "subadmin" sends HTTP method "DELETE" to OCS API endpoint "/cloud/users/newsubadmin/subadmins" with body
       | groupid | new-group |
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the user "newsubadmin" should be the subadmin of the group "new-group"
 
-  @skip @issue-31276
+  @issue-31276
   Scenario: normal user tries to remove subadmin in the group
     Given user "subadmin" has been created
     And user "newuser" has been created
@@ -41,5 +42,6 @@ Feature: remove subadmin
     When user "newuser" sends HTTP method "DELETE" to OCS API endpoint "/cloud/users/subadmin/subadmins" with body
       | groupid | new-group |
     Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
     And the user "subadmin" should be the subadmin of the group "new-group"
diff --git a/tests/acceptance/features/apiShareManagement/createShare.feature b/tests/acceptance/features/apiShareManagement/createShare.feature
@@ -143,7 +143,7 @@ Feature: sharing
       | ocs_api_version | ocs_status_code |
       | 1               | 997             |
 
-  @skip @issue-32068
+  @issue-32068
   Scenario: Creating a new share with a disabled user
     Given using OCS API version "2"
     And user "user1" has been created
@@ -152,7 +152,8 @@ Feature: sharing
       | path      | welcome.txt |
       | shareWith | user1       |
       | shareType | 0           |
-    Then the OCS status code should be "401"
+    Then the OCS status code should be "997"
+    #And the OCS status code should be "401"
     And the HTTP status code should be "401"
 
   @public_link_share-feature-required