Use transactions when renaming directory contents

owncloud · Feb 6, 2015 · 6c00521 · 6c00521
1 parent 80e38b8
commit 6c00521
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/private/files/cache/cache.php b/lib/private/files/cache/cache.php
@@ -408,12 +408,14 @@ public function move($source, $target) {
 			$result = \OC_DB::executeAudited($sql, array($this->getNumericStorageId(), $source . '/%'));
 			$childEntries = $result->fetchAll();
 			$sourceLength = strlen($source);
+			\OC_DB::beginTransaction();
 			$query = \OC_DB::prepare('UPDATE `*PREFIX*filecache` SET `path` = ?, `path_hash` = ? WHERE `fileid` = ?');
 
 			foreach ($childEntries as $child) {
 				$targetPath = $target . substr($child['path'], $sourceLength);
 				\OC_DB::executeAudited($query, array($targetPath, md5($targetPath), $child['fileid']));
 			}
+			\OC_DB::commit();
 		}
 
 		$sql = 'UPDATE `*PREFIX*filecache` SET `path` = ?, `path_hash` = ?, `name` = ?, `parent` =? WHERE `fileid` = ?';