Merge pull request #13854 from owncloud/avatar-exists

Add a better way to check if an avatar exists for the user
owncloud · Feb 9, 2015 · 5d8f1a1 · 5d8f1a1
2 parents dc475ab + c644ed8
commit 5d8f1a1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/lib/private/avatar.php b/lib/private/avatar.php
@@ -42,6 +42,15 @@ public function get ($size = 64) {
 		return $avatar;
 	}
 
+	/**
+	 * Check if an avatar exists for the user
+	 *
+	 * @return bool
+	 */
+	public function exists() {
+		return $this->view->file_exists('avatar.jpg') || $this->view->file_exists('avatar.png');
+	}
+
 	/**
 	 * sets the users avatar
 	 * @param \OC_Image|resource|string $data OC_Image, imagedata or path to set a new avatar

diff --git a/lib/private/helper.php b/lib/private/helper.php
@@ -289,12 +289,7 @@ public static function publicPreviewIcon( $path, $token ) {
 	**/
 	public static function userAvatarSet($user) {
 		$avatar = new \OC_Avatar($user);
-		$image = $avatar->get(1);
-		if ($image instanceof \OC_Image) {
-			return true;
-		} else {
-			return false;
-		}
+		return $avatar->exists();
 	}
 
 	/**

diff --git a/lib/public/iavatar.php b/lib/public/iavatar.php
@@ -20,6 +20,13 @@ interface IAvatar {
 	 */
 	function get($size = 64);
 
+	/**
+	 * Check if an avatar exists for the user
+	 *
+	 * @return bool
+	 */
+	public function exists();
+
 	/**
 	 * sets the users avatar
 	 * @param Image $data mixed imagedata or path to set a new avatar