Correctly close handle of directory when listing certificates

owncloud · Nov 17, 2014 · 39ae569 · 39ae569
1 parent b228226
commit 39ae569
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/private/security/certificatemanager.php b/lib/private/security/certificatemanager.php
@@ -49,6 +49,7 @@ public function listCertificates() {
 				} catch(\Exception $e) {}
 			}
 		}
+		closedir($handle);
 		return $result;
 	}
 

diff --git a/tests/lib/security/certificatemanager.php b/tests/lib/security/certificatemanager.php
@@ -8,7 +8,7 @@
 
 use \OC\Security\CertificateManager;
 
-class CertificateManagerTest extends \PHPUnit_Framework_TestCase {
+class CertificateManagerTest extends \Test\TestCase {
 
 	/** @var CertificateManager */
 	private $certificateManager;
@@ -18,8 +18,8 @@ class CertificateManagerTest extends \PHPUnit_Framework_TestCase {
 	private $user;
 
 	function setUp() {
-		$this->username = OC_Util::generateRandomBytes(20);
-		OC_User::createUser($this->username, OC_Util::generateRandomBytes(20));
+		$this->username = $this->getUniqueID('', 20);
+		OC_User::createUser($this->username, $this->getUniqueID('', 20));
 
 		\OC_Util::tearDownFS();
 		\OC_User::setUserId('');
-Original file line number
+Diff line change
@@ Expand Up / @@ -49,6 +49,7 @@ public function listCertificates() { @@
     				} catch(\Exception $e) {}
     			}
     		}
+    		closedir($handle);
     		return $result;
     	}
@@ Expand Down @@