[stable10] Backport of Fix re-encrypting encrypted files

When the files are already encrypted the files need not be encrypted again. Signed-off-by: Sujith H <[email protected]>
owncloud · Oct 16, 2018 · 1eff2f4 · 1eff2f4
1 parent 8119395
commit 1eff2f4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/apps/encryption/lib/Crypto/EncryptAll.php b/apps/encryption/lib/Crypto/EncryptAll.php
@@ -297,7 +297,10 @@ protected function encryptFile($path) {
 		$target = $path . '.encrypted.' . $this->getTimeStamp() . '.part';
 
 		try {
-			$this->keyManager->setVersion($source, 0, $this->rootView);
+			$version = $this->keyManager->getVersion($source, $this->rootView);
+			if ($version > 0)  {
+				return false;
+			}
 			$this->rootView->copy($source, $target);
 			$this->rootView->rename($target, $source);
 		} catch (DecryptionFailedException $e) {

diff --git a/apps/encryption/tests/Crypto/EncryptAllTest.php b/apps/encryption/tests/Crypto/EncryptAllTest.php
@@ -673,4 +673,12 @@ public function testGetTimeStamp() {
 		$result = $this->invokePrivate($encryptAll, 'getTimeStamp', []);
 		$this->assertGreaterThan(10000, $result);
 	}
+
+	public function testEncryptAlreadyEncryptedFile() {
+		$this->keyManager->method('getVersion')
+			->with('/user1/files/bar.txt', $this->view)
+			->willReturn(1);
+		$result = $this->invokePrivate($this->encryptAll, 'encryptFile', ['/user1/files/bar.txt']);
+		$this->assertFalse($result);
+	}
 }