Merge pull request #14883 from owncloud/imagepng_expects_resource_issue

validate resource's integrity before using it
owncloud · Mar 16, 2015 · 1075914 · 1075914
2 parents 997a7a2 + 09b0537
commit 1075914
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/private/image.php b/lib/private/image.php
@@ -283,9 +283,12 @@ public function resource() {
 	}
 
 	/**
-	 * @return string Returns the raw image data.
+	 * @return null|string Returns the raw image data.
 	 */
 	function data() {
+		if (!$this->valid()) {
+			return null;
+		}
 		ob_start();
 		switch ($this->mimeType) {
 			case "image/png":

diff --git a/tests/lib/image.php b/tests/lib/image.php
@@ -144,6 +144,11 @@ public function testData() {
 		$this->assertEquals($expected, $img->data());
 	}
 
+	public function testDataNoResource() {
+		$img = new \OC_Image();
+		$this->assertNull($img->data());
+	}
+
 	/**
 	 * @depends testData
 	 */