Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .drone.star and drop PHP 7.2 #723

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Update .drone.star and drop PHP 7.2 #723

merged 1 commit into from
Sep 6, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis self-assigned this Sep 4, 2021
@mmattel
Copy link
Contributor

mmattel commented Sep 5, 2021

Regarding the failing CI, seems that composer is not installed:
Makefile:44: *** composer is not available on your system, please install composer. Stop.

@phil-davis
Copy link
Contributor Author

I removed the check from Makefile - that check is often annoying, and specially now with steps that use Makefile targets that do not require PHP or composer. It has been removed in other repos, so I need to remember to do it in each repo that I update!

@phil-davis phil-davis requested a review from jasson99 September 6, 2021 03:37
@phil-davis phil-davis force-pushed the update-drone-star-20210904 branch from b24e9a9 to 5cb68da Compare September 6, 2021 07:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dpakach dpakach merged commit 4caab98 into master Sep 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-drone-star-20210904 branch September 6, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@jasson99 jasson99 Awaiting requested review from jasson99

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @mmattel @dpakach