-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First contact load fix, direct access to contact, contact not in group, group load and order - fix #312 #323
Conversation
By analyzing the blame information on this pull request, we identified @irgendwie, @tomneedham and @DeepDiver1975 to be potential reviewers |
Current coverage is
|
e083112
to
130ae25
Compare
aa8b250
to
69207c9
Compare
@Henni :) |
951bc09
to
bfdd692
Compare
Rebased with small fix. |
ba45217
to
dedf6fe
Compare
@jancborchardt a little review here too? |
@skjnldsv everyone knows you can only buy PRs with 🍻 ;) I'll do some batch reviewing when I'm back at the desk this evening. |
Damn, busted! :3 Edit: @tomneedham, well? :D |
8f874cd
to
2db27bd
Compare
Fixed a small conflict with the group selection on mobile view. |
@skjnldsv rebase again :) @tomneedham you wanna earn your 🍻? |
2db27bd
to
dabce47
Compare
Rebased and ready to merge. |
gid: $routeParams.gid, | ||
uid: undefined | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this else clause removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it was causing issues. It was replaced by this test:
if (ctrl.contactList[i].uid() === ev.uid) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bd5c73a
to
74ff3b5
Compare
Fix multiple issues: