Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #233

Merged
merged 3 commits into from
Mar 19, 2016
Merged

Small fixes #233

merged 3 commits into from
Mar 19, 2016

Conversation

irgendwie
Copy link
Contributor

fixes #24
fixes #72

cc @Henni

@irgendwie irgendwie added this to the 1.1-next milestone Mar 18, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @tomneedham, @DeepDiver1975 and @Henni to be potential reviewers

@Henni
Copy link
Contributor

Henni commented Mar 18, 2016

@irgendwie https://github.com/blog/1506-closing-issues-via-pull-requests

@irgendwie
Copy link
Contributor Author

Review pls @Henni

@Henni
Copy link
Contributor

Henni commented Mar 19, 2016

  • Only show no-search-result message if search is not empty. 94c3b34
  • Update uid if no contact in group. db091e4
  • Load first contact on initial load. 5778c3b

@irgendwie on initial load a contact is chosen, but not necessarily the first one. (Maybe you are choosing the first by uid!?)

@irgendwie
Copy link
Contributor Author

@Henni Changed to fullName(); 411155b
Can get merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

»No contacts« placeholder should not show until everything is loaded Show first contact by default
3 participants