Cache the value of last unfinished job in the PropagateDerectory scheduleNextJob #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrow4a
force-pushed
the
reduce_loops_dirjob
branch
from
f9bc21e to
a2d2690
Compare
|
On a more general note: We're using |
ogoffart
reviewed
Oct 27, 2016
| @@ -194,11 +194,12 @@ class OWNCLOUDSYNC_EXPORT PropagateDirectory : public PropagatorJob { | |||
|
|
|||
| int _jobsFinished; // number of jobs that have completed | |||
| int _runningNow; // number of subJobs running right now | |||
| SyncFileItem::Status _hasError; // NoStatus, or NormalError / SoftError if there was an error | |||
| SyncFileItem::Status _hasError; // NoStatus, or NormalError / SoftError if there was an errorv | |||
|
Looks good (appart from the typo in the comment) |
mrow4a
force-pushed
the
reduce_loops_dirjob
branch
from
a2d2690 to
34c59ba
Compare
|
Ok, done. Ready to merge if checks will pass. |
ogoffart
approved these changes
Oct 31, 2016
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem discussed in this PR #5269, implementing the solution of @ckamm which appears to work :
I did not run in any race condition and manualy tested most of the cases. Hope this will work out
@guruz @ogoffart