New Activity View #4083
New Activity View #4083
Conversation
This a first step to integrate the server activity view, see #3732
Keep one instance for the lifetime of the generalsettings widget.
Currently, this one only replaces colons by / on Mac platform. This makes the function resuseable.
This is the new widget to display server activity.
It is better to create the tabs from the code in SettingsDialog.
Do not use it via a smart pointer class.
Now it can be used to be set on the other two treeviews.
So there are three views now: One displaying the server activities, one for the sync protocol and a third one for ignored files and issues.
|
Isn’t the goal still to make it similar to the web-app activity view? As in, similarly simple to see what happened, with nice profile images of other people who shared stuff with you, file thumbnails, ability to share files from there / open them locally etc.? Keep in mind those are just plans and we should of course do this step-by-step, but this 3-tab view is more complicated than the current view. One problem it solves is that errors drown in the log – but the proposal for that from me since long ago was to just keep them at the top. See: In »Activity«, keep errors at the top #1745 (from May last year without reply from anyone of you). |
|
About "similar to the web-app": Yes, we want to make more useful. However, the current available API does not allow more than what I have implemented so far. The needed data is not available. A new API is in discussion here: owncloud/activity#405 About the "three tab solution": It is better for the user to have the three tabs. The main focus is on the default tab which is the server activity, as @karlitschek wanted. In Berlin we agreed to combine the server api and the client sync protocol, however, that is currently not possible due to missing API capabilities. So we want to keep the sync protocol as people are using it to verify their syncs. I will answer on why I think it makes sense to have a separate tab with "bugs" in #1745 |
Why is it better to have three? I also answered in #1745 (comment) |
|
I tried to explain this. If there are real issues, they are displayed more prominent at the account settings anyway. So this is for people who want to dig deeper anyway. We are talking here about files that were not synced. That is only in rare cases an error condition. Mostly it's intentional by ignore patterns. Note that we are away from literally syncing everything, and do not want to go there with our selective sync and ignore patterns. So what we are talking here is mainly a list of ignored files. That must be available somewhere. > Why is it better to have three? @jancborchardt before talking down the practical solution I was coming up here with (also based on a very difficult API) please take the time to really dig into the nifty details and come up with proposals for better solutions which take the given circumstances into consideration. |
|
I think it is fine for the 2.1 |
|
Could "Not synced" be renamed to "Issues" and you also list created conflict files there? This was requested at several other points here on github. |
I’m not sure, as I said. It’s more complicated.
We did that at the conf. It seems like all of that was forgotten? See also the email I just sent for a recounting of what we talked about. I can mock this up, if needed, but I guess coming to Nürnberg and working face-to-face on a whiteboard seems to be the correct way to settle this without another misunderstanding. |
|
Maybe cc @ogoffart whom I specifically talked to about the redesign of this. |
The ProtocolWidget is now the Activitytab Widget
|
Maybe add symbols in the Aktion row for Up and Download? |
It uses the Account displayName to destinguish.
Display the activity entries in a different mode if the account is not longer connected.
This gives a visual indication of the account not being connected and as a result maybe outdated activity data.
Note that the activity has also entries of files that are not synced so that not every activity entry has to have a local pendant. Also, one activity entry can reference multiple files, so only the first one is shown.
the original text might be elided.
I'd like to create this pull request already to discuss the changes done here as early as possible.
This branch changes the way we display the sync activity in the former client releases and adds three new views to the Activity-tab in the client.
This displays the server activity list. Currently it is pulled from the server and displayed if the server is reachable.
Very similar to the former list of synced files, but without the ignored and error files in between. It's a plain positive list now.
A list of files that were not successfully synced because they were ignored (by user intention or because of other reasons) Later on we can also handle the blacklisting here more user friendly.
Some Screenshots:
Please give me your feedback on this changes and if you think they help to improve user experience. Nothing is set in stone yet, please do not stumble above details. @MTRichards @moscicki @jancborchardt @DeepDiver1975 @karlitschek
Thanks