Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Move the ConfigFile class out of libsync #6213

Open
ogoffart opened this issue Dec 4, 2017 · 3 comments
Open

Refactoring: Move the ConfigFile class out of libsync #6213

ogoffart opened this issue Dec 4, 2017 · 3 comments
Assignees
Milestone

Comments

@ogoffart
Copy link
Contributor

ogoffart commented Dec 4, 2017

ConfigFile is currently in the libsync folder.
However, the sync engine should not read directly from the config file but should have all its parameter passed in the SyncOptions class.

Rationale: We don't want the tests, owncloudcmd, or other applications to share or mess with the same config file.

@ogoffart ogoffart self-assigned this Dec 4, 2017
@guruz guruz modified the milestones: 2.4.0, 2.5.0 Dec 4, 2017
ogoffart added a commit that referenced this issue Dec 6, 2017
…etwork job

Remove one dependency from the config file for the sync engine.
Part of issue #6213
ogoffart added a commit that referenced this issue Dec 6, 2017
ogoffart added a commit that referenced this issue Dec 7, 2017
…etwork job

Remove one dependency from the config file for the sync engine.
Part of issue #6213
ogoffart added a commit that referenced this issue Dec 7, 2017
ogoffart added a commit that referenced this issue Dec 7, 2017
…etwork job

Remove one dependency from the config file for the sync engine.
Part of issue #6213
ogoffart added a commit that referenced this issue Dec 7, 2017
ogoffart added a commit that referenced this issue Dec 7, 2017
…etwork job

Remove one dependency from the config file for the sync engine.
Part of issue #6213
ogoffart added a commit that referenced this issue Dec 7, 2017
@guruz guruz added the ReadyToTest QA, please validate the fix/enhancement label Dec 12, 2017
@ogoffart ogoffart removed the ReadyToTest QA, please validate the fix/enhancement label Feb 20, 2018
@guruz
Copy link
Contributor

guruz commented Mar 26, 2018

Only place missing:

src/libsync/creds/httpcredentials.cpp:    auto settings = ConfigFile::settingsWithGroup(Theme::instance()->appName());

@ckamm
Copy link
Contributor

ckamm commented Apr 19, 2018

So it looks like we need to move the parts of HttpCredentials that interact with the keychain into gui and we're done. I don't think it's critical for 2.6, moving.

@ckamm ckamm modified the milestones: 2.5.0, 2.6.0 Apr 19, 2018
@ogoffart
Copy link
Contributor Author

Right, we will refactor the credentials once we can get rid of shibboleth

@TheOneRing TheOneRing self-assigned this Sep 15, 2020
@TheOneRing TheOneRing modified the milestones: 2.8.0, 2.9.0 Mar 17, 2021
@TheOneRing TheOneRing modified the milestones: 2.11, 2.12 May 4, 2022
@TheOneRing TheOneRing modified the milestones: 4.0, Backlog Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants