[Activity View] If you disable the Activity app you should not see the server activity tin the activity tab

[cdamken]

Steps to reproduce

1. Open your ownCloud desktop client 2. Disable Activity app in the server.
2. Go to the Desktop client
3. Go to Open Folder "ownCloud"
4. Create a new folder, called aaa
5. Right click on the folder aaa
6. Select share with ownCloud
7. Share with other user (e.g. user1)
8. Wait to sync

Expected behavior

The activity tab should not be shown (hidden). (If multi-account if all the servers are disabled)

Actual behavior

No message appears "The administrator has disabled the activity for this server"
Related #3732 #4163

@MorrisJobke @dragotin
00004066

[dragotin]

This needs testing!

[SergioBertolinSG]

Not sure what is expected here.

This message "The administrator has disabled the activity for this server" doesn't appear.

But activity tab dissapears and appears correctly.

In OS X I cannot test it (at least following the exact steps), it is blocked by #4650

[dragotin]

I think it is fine that there is just no tab if the activity tab is disabled. The message will appear if there is a notification and thus the Activity Tab appears.

[mcastroSG]

Hi hi:

Steps executed

1. As admin, disable Activity app in the server.
2. Wait for sync.
3. Open your ownCloud desktop client to check that Server Activity tab disappears.
4. As admin, generate a new notification with Notification App.
5. Wait for sync.

Results

Server Activity tab is not shown at Settings > Activity until server generates a new notification and client sync. At that moment Server Activity tab appears showing notification and the message "Accout XXXX@XXXXX:XXXX does not have activities enabled" appears at the bottom. After closing the notification and wait for next sync Server Activity tab disappears again.

MacOS
Client Version: Version 2.2.0-nightly20160420 (build 3284)
Client OS: MacOS X El Capitan 10.11.4
Server Version: 9.1 Alpha
Server OS: Ubuntu

Windows
Client Version: Version 2.2.0-nightly20160420 (build 6003)
Client OS: Windows 10
Server Version: 9.1 Alpha
Server OS: Ubuntu

Regards

[mcastroSG]

@cdamken is the current behaviour ok?

Results

Server Activity tab is not shown at Settings > Activity until server generates a new notification and client sync. At that moment Server Activity tab appears showing notification and the message "Accout XXXX@XXXXX:XXXX does not have activities enabled" appears at the bottom. After closing the notification and wait for next sync Server Activity tab disappears again.

[cdamken]

@mcastroSG Looks good for me 👍 Thanks