-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully Handle Storage Limitations Errors #3736
Comments
We have been reporting in the user intefrace the errors from the server for a long time. Is there any specific example we need to test? What is wrong with the current behaviour? |
This was the outcome of our Berlin meetings, where the team said that we could stop checking for illegal characters on the client, and have the server do it instead. This would result in new errors, and that we were now in a place where the server could start to pass those along to the user so that we could tell them when, for example, illegal characters were not allowed to be synced because of a backend limitation. Until now, we have checked for those in the client and prevented sync, but the concept here is to try to sync with the server, and then the server lets the client know the errors based on what the backend allows to happen, not a pre-set list in the client. If I recall correctly. @DeepDiver1975 was involved in the specifics, as was @dragotin @danimo and others. |
If the server does not support it, then the server will reply with an error
I tested this issue: With this characters (<, >, /, *, ?, '', |) on Winodws is working OK when you create a new Folder/File. If you go to Activity options you can see this message (The file name contains invalid characters that can not be ......) BUT: With this character () I can't create a Folder o File on Server (you can see "Could not create folder, File name contains at least one invalid character") Desktop v ownCloud-2.1.0.5584-nightly20151027-setup.exe |
Yes, that's the expected error. |
Thanks |
… names We changed the discovery code not to ignore files whose filename contains charachter invalid on windows. (Because newer versions of the server supports them) Servers older than 8.1 will just say "Bad Request" as an error and it's a regression against previous client version. So keep nice error even with older server. Relates to #3736
As an admin, I want filename characters (and other storage limitations) that are not allowed on certain ownCloud back end storage types to throw an error that the desktop client can understand, and then the desktop client notifies the user of the error
Example: certain special characters on SMB storage.
Acceptance Criteria:
The text was updated successfully, but these errors were encountered: