-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 503 reply code properly #2884
Comments
@ckamm I felt free to assign you here. For case 1. (which can be easily tested by setting maintenance = true in servers config.php) the problem is that in object Folder and in Folderman the variable |
@dragotin Currently the behavior is that the 503 response will make the 'service unavailable' error appear in the UI and show the account as disconnected (AccountState goes to NetworkError). You're saying we should hide the error and silently try again? We could do that for a bit, but I don't want to pretend to be connected while we can't actually sync anything for too long. The 503 response could have other causes and be permanent. What's the problem we want to solve? Would trying again for a minute and then giving up be good? I'll check out 2. now. |
About 2.: The commit fixes it. It'd be really nice if we could distinguish this 'maintenance mode!' and 'storage unavailable!' from regular 503 errors that could have other causes. |
Refs #1923 |
What was done:
What was not done: A server-maintenance 503 during remote discovery will still abort the sync with an error. |
Tested case 1 in version 1.8.0-nightly20150302 (build 2068). It is fixed. |
There are two scenarios where the server replies 503:
We need to fix that.
The text was updated successfully, but these errors were encountered: