Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Pause-Option #1971

Closed
stonerl opened this issue Jul 15, 2014 · 20 comments
Closed

Global Pause-Option #1971

stonerl opened this issue Jul 15, 2014 · 20 comments

Comments

@stonerl
Copy link

stonerl commented Jul 15, 2014

Is was wondering if it would be possible to implement something like a Global Pause-Button. At the moment it is possible to pause syncing for single Folders. The motivation behind this request is, that I sometimes tether my notebook with my phone an I don't want owncloud to sync during this time.

I know that I also could quit owncloud and restart it when I'm back on a "normal" connection, but having such a pause option would be quite handy. Maybe this Global Pause-Option could be configurable, like:

Pause for: 10min, 15min, 30min ... "resume manually"

Edit (@danimo): The implementation should also contain a possiblity to pause/unpause from the command line as to hook it up to scripts, see #2760.

@eslngr
Copy link

eslngr commented Nov 7, 2014

I have to pause very often to prevent application (photoshop, after effects) crashes and/or file-corruptions and found entering the settings very annoying over the time. Also quitting or logging out is no option because i still like to be notified about changes to other files that are made.

@te-online
Copy link

+1 for this enhancement. Might not be too hard to implement, as there already is an option to pause every single account.
If you regularly work while being on mobile data plan, you don't want owncloud to sync big stuff. My solution for now is to quit owncloud for that time, but than I often forget to start it again afterwards.
An option to only sync files under 2 megabyte or so would be awesome, but maybe overkill.

danimo pushed a commit that referenced this issue Jan 18, 2015
@danimo
Copy link
Contributor

danimo commented Jan 18, 2015

Feel free to continue on the branch I pushed (some code that I had lying around half-baked and ported to master now). The following is missing:

  • Blessing of the approach by @jancborchardt
  • Some kind of reflection of a global pause state in the settings/status dialog
  • Persistence of the pause state across restart
  • When paused, replace "Up to date". That's not true when paused, because we do not know.

Who wants to pick this up? I'm glad to help. It should only require basic programming skills.

@danimo
Copy link
Contributor

danimo commented Jan 18, 2015

This is how it currently looks:

image

@te-online
Copy link

Looks great. I might try to look into it to see what I can do by end of next week.

@danimo
Copy link
Contributor

danimo commented Jan 18, 2015

@te-online Also, the local pause option should maybe be renamed to Enable/Disable again, so it's not too confusing.

@jancborchardt
Copy link
Member

@danimo can you show a screenshot of both states – when it’s paused and when it’s running?

@danimo
Copy link
Contributor

danimo commented Jan 27, 2015

@jancborchardt No, I don't have a build of that branch at hand. if it's running it shows whatever state there is as an icon, and the checkmark in front of "Pause syncing" goes away.

@jancborchardt
Copy link
Member

Ok, that seems to be the best solution. If we would change it to »Syncing paused« it would create confusion as how to unpause.

@jancborchardt
Copy link
Member

(I’d still prefer the »Pause« button on the same line as the Syncing / Up to date, but I know that’s probably not possible cross-platform. ;)

@te-online
Copy link

Sorry, it seems I don't have any time to look into this at the moment. It might be a one-liner, but I'd have to set up the whole development environment, because I didn't work on the client so far. When there's more freetime, I will be happy to have a look at it.

In the meantime, everybody feel free to implement it. :-)

(I’d still prefer the »Pause« button on the same line as the Syncing / Up to date, but I know that’s probably not possible cross-platform. ;)

Even if it was possible, I don't see any space there. There are advantages of having it on a single line. It's always accessible, no matter what syncing state is being displayed.

@danimo
Copy link
Contributor

danimo commented Feb 3, 2015

Related: #2760

@guruz
Copy link
Contributor

guruz commented May 6, 2015

For the record, DropBox:

dropbox

OneDrive:

onedrive

(it even has the Sync now proposed in #2158)

@guruz
Copy link
Contributor

guruz commented May 6, 2015

@dragotin mentions in #3185 (comment)

In the light of multi account however, global probably means by account.

IMHO we can still do it globally and have it pause all accounts.

@danimo
Copy link
Contributor

danimo commented May 6, 2015

For reference: this is in the https://github.com/owncloud/client/tree/global_pause branch.

danimo pushed a commit that referenced this issue May 7, 2015
@guruz
Copy link
Contributor

guruz commented Aug 27, 2015

Even more relevant now given that we have multi-account support..

@martin-rueegg
Copy link

👍 for the global option

use cases:

  • since ssl transport gets interpreted as real-time traffic, it blocks everything else. yes, i'm aware of the bwlimit, yet i want to set the upload bwlimit to let's say 80% of the line's capacity (otherwise i will never upload my 100GB!). this is usually enough for http GETs [and DNS requests in the first place] to go through and the download is not the problem. yet, getting an incoming VoIP-call requires me to reduce the load on the line, thus a global (not per-accound) pause.
  • same when on the road with my notebook. yes, i can quit the owncloud client, but then i have to remember to restart it. seeing the "paused" icon in the tray helps me to remember.

(client: Version 2.1.0 (build 5683). Windows.)

@JKawohl
Copy link
Contributor

JKawohl commented Oct 11, 2016

Is this done and can be closed?
screen shot 2016-10-11 at 14 54 25

@dragotin
Copy link
Contributor

Obviously....

@martin-rueegg
Copy link

Fantastic! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants