Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Fix unit tests related to core issue 37358 and core PR 37103 #150

Merged
merged 1 commit into from
May 7, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 7, 2020

Part of issue owncloud/core#37358

The signature of core lib/private/User/Manager.php get() changed to have a new 2nd parameter.
See core PR owncloud/core#37103

Adjust unit tests so that the mocking of userManager matches the way that phpunit sees the calls. Even though the new parameter is optional (has a default value), phpunit sees the call happening with the parameter having been set to its default value false

@phil-davis phil-davis self-assigned this May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #150   +/-   ##
=========================================
  Coverage     98.83%   98.83%           
  Complexity       60       60           
=========================================
  Files             8        8           
  Lines           258      258           
=========================================
  Hits            255      255           
  Misses            3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e52f4...028b475. Read the comment docs.

@phil-davis phil-davis requested review from VicDeo and jvillafanez May 7, 2020 04:41
@phil-davis phil-davis merged commit dea612e into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the unit-tests-core-isssue-37358 branch May 7, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants