add the state parameter to the oidc authentication request #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
IljaN
reviewed
Dec 3, 2021
| @@ -445,13 +448,15 @@ class LoginActivity : AppCompatActivity(), SslUntrustedCertDialog.OnSslUntrusted | |||
| val customTabsBuilder: CustomTabsIntent.Builder = CustomTabsIntent.Builder() | |||
| val customTabsIntent: CustomTabsIntent = customTabsBuilder.build() | |||
|
|
|||
| this.oidcState = UUID.randomUUID().toString().substring(0,15) | |||
There was a problem hiding this comment.
Isn't it better to use base64 encoded bytes from SecureRandom here?
There was a problem hiding this comment.
definitely better, created a new function in OauthUtils for that
abelgardep
suggested changes
Dec 15, 2021
There was a problem hiding this comment.
Just a tiny change and we are ready to go @mortbauer
BTW, rebase this branch with master when you can 👍
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/authentication/LoginActivity.kt
Outdated
Show resolved
Hide resolved
* added state paramter to make resilient against CSRF attacks * see issue owncloud#3465 for more information
mortbauer
force-pushed
the
feature/oidc-with-state-parameter
branch
from
690ab7b to
b826444
Compare
abelgardep
approved these changes
Dec 16, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
QA checks, regression from current authentication methods
Approved from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues