Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429

davigonz · 2019-01-23T16:16:39Z

Implements #1799
Include switch to allow or disallow light filtering from other apps like Twilight or similars

BUGS & IMPROVEMENTS

(1) Camera folder picker Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429 (comment) [FIXED]
(2) Passcode lock crashes Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429 (comment) [FIXED]
(3) Detail view crashes Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429 (comment) [FIXED]
(4) Crash open files Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429 (comment) [FIXED]
(5) Crash file upload Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429 (comment) [FIXED]
(6) Uploads view obscured by light filter Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429 (comment) [FIXED]

davigonz · 2019-01-29T16:38:00Z

@hosy @SD1998 @hannesa2 you can review this PR as well, do not panic about the amount of changes, many of them are from automatic code reformat

hannesa2 · 2019-01-29T21:54:40Z

I know this issue about amount of changes on non-well formated code.
I at least split format changes and logic to different commits to make it for reviewers a more easy task.
That's why I split PRs into codeformat, lint and logic.
Advantage: codeformat is a no-brainer but causes often the biggest changers and could be done much faster

I warmly recommend to split, so here is my suggestion:

squash all
open commit git reset --soft HEAD^
start again with git add by first git reset .
add partial changes to individual commits git add . -p

then it's much easier and I will do

hannesa2 · 2019-01-29T22:02:00Z

Ok, I tried, but I gave up. Owncloud needs first a well formated code !
These PR's are the worst, where logic changes are camouflaged by codestyle changed >100 files

Doing so, we have to

merge Android Studio 3.3 android-library#228 to have an every developer machine same Android Studio
merge Codestyle android-library#224 to have same codstyle (a lot of changes but this is a I've-nothing-to-think-about)
merge Android Studio 3.3 #2424 to have an every developer machine same Android Studio
I will create codestyle PR in https://github.com/owncloud/android (this is a I've-nothing-to-think-about too)
rebase this PR on new master
squash all
open commit git reset --soft HEAD^
start again with git add by first git reset .
add partial changes to individual commits git add . -p

davigonz · 2019-02-01T10:12:38Z

@hannesa2 just got rid of most of the format changes, I could not delete some of them because appeared along with logic changes in the hunks while using git add . -p

I will create codestyle PR in https://github.com/owncloud/android (this is a I've-nothing-to-think-about too)

Let's face the format changes there then

davigonz · 2019-02-06T10:14:25Z

4. I will create codestyle PR in https://github.com/owncloud/android (this is a I've-nothing-to-think-about too)

@hannesa2 codestyle in library and Android Studio 3.3 in both app and library are already merged, can you please create a codestyle PR in https://github.com/owncloud/android as you said before?

hosy · 2019-02-12T10:21:16Z

@davigonz please can you resolve the conflicts, before we start a review?

davigonz · 2019-02-12T15:52:36Z

please can you resolve the conflicts, before we start a review?

@hosy done

davigonz · 2019-02-14T09:59:36Z

More conflicts, fixing them...

davigonz · 2019-02-18T10:16:13Z

@hosy @abelgardep @hannesa2 can you please have a look at this PR, approving it or requesting some changes if needed? Thanks

jesmrec · 2019-02-21T09:55:36Z

Let's QA this by checking the option enabled allows tapping everywhere with filter.

jesmrec · 2019-02-21T09:57:02Z

(1) [FIXED]

Twilight enabled and option "Touches with other visible windows" enabled
Settings -> enable camera uploads -> Camera folder

Current: Taps not allowed in the picker
Expected: Taps allowed

Nexus 6P v7

jesmrec · 2019-02-21T10:05:15Z

(2) [FIXED]

Passcode lock crashes when it is enabled, regardless any other option

Stacktrace:


11:04:50.743 25790-25790/com.owncloud.android.debug E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.owncloud.android.debug, PID: 25790
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.owncloud.android.debug/com.owncloud.android.ui.activity.PassCodeActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setFilterTouchesWhenObscured(boolean)' on a null object reference

jesmrec · 2019-02-21T10:56:14Z

(3) [FIXED]

No necessary the filter enabled

Select a file in multiselection mode
Select "Details"

Current: crash
Expected: details view

jesmrec · 2019-02-21T11:02:43Z

(4) [FIXED]

No necessary the filter enabled

Tap on a txt file in order to download it

Current: crash
Expected: file opened

Stack trace:

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.owncloud.android.debug, PID: 1527
    java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.View android.app.Activity.findViewById(int)' on a null object reference
        at com.owncloud.android.ui.fragment.FileDetailFragment.<init>(FileDetailFragment.java:110)
        at com.owncloud.android.ui.fragment.FileDetailFragment.newInstance(FileDetailFragment.java:90)
        at com.owncloud.android.ui.activity.FileDisplayActivity.startSyncThenOpen(FileDisplayActivity.java:1854)
        at com.owncloud.android.ui.fragment.OCFileListFragment.onItemClick(OCFileListFragment.java:821)

jesmrec · 2019-02-21T13:00:46Z

(5) [FIXED]

open FAB -> Upload -> Files

Current: App crashes
Expected: file picker

Stacktrace:

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.owncloud.android.debug, PID: 6855
    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.owncloud.android.debug/com.owncloud.android.ui.activity.UploadFilesActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setFilterTouchesWhenObscured(boolean)' on a null object reference

jesmrec · 2019-02-21T14:12:05Z

(6)

Uploads view is obscured by the light filter. Not posible to click in the cells, remove items from the list etc...

jesmrec · 2019-02-22T12:56:57Z

All stuff fixed. Approved on my side.

davigonz mentioned this pull request Jan 23, 2019

App not responding to touch events #1799

Closed

davigonz changed the title ~~Include switch to allow or disallow ligth filtering from other apps~~ Include switch to allow or disallow light filtering from other apps like Twilight or similars Jan 23, 2019

davigonz self-assigned this Jan 29, 2019

davigonz requested a review from hosy January 29, 2019 16:39

davigonz force-pushed the feature/light_filter_switch branch 2 times, most recently from 2fc3195 to 0c9d490 Compare February 1, 2019 10:06

davigonz force-pushed the feature/light_filter_switch branch from 0c9d490 to e6755e6 Compare February 12, 2019 15:52

davigonz requested a review from hannesa2 February 12, 2019 15:52

davigonz force-pushed the feature/light_filter_switch branch from e6755e6 to af8f416 Compare February 13, 2019 16:11

davigonz force-pushed the feature/light_filter_switch branch 3 times, most recently from af89d8c to b11791c Compare February 18, 2019 07:43

davigonz requested a review from abelgardep February 18, 2019 07:59

davigonz mentioned this pull request Feb 20, 2019

Code style #2447

Merged

hosy approved these changes Feb 20, 2019

View reviewed changes

davigonz requested a review from jesmrec February 20, 2019 15:24

davigonz force-pushed the feature/light_filter_switch branch from b11791c to 3a6a3c1 Compare February 21, 2019 07:50

davigonz added the code approved label Feb 21, 2019

davigonz added 9 commits February 22, 2019 09:01

Include switch to allow or disallow touch filtering

90d5cf1

Fix some build errors

c2b76ec

Allow touches within listfragment in UploadFilesActivity

937d9ad

Solve conflicts

682f9cf

Fix bug detail view crashes

9cbb0d5

Fix passcode crash

2c3c4ab

Fix camera folder picker bug

63a3eb0

Fix crash when uploading files

dad030f

Fix uploads view does not respond when light filtering option is enabled

7fade16

davigonz force-pushed the feature/light_filter_switch branch from 6215ad2 to 7fade16 Compare February 22, 2019 08:04

jesmrec approved these changes Feb 22, 2019

View reviewed changes

jesmrec added the Approved by qa label Feb 22, 2019

davigonz merged commit bfdf35f into master Feb 22, 2019

delete-merged-branch bot deleted the feature/light_filter_switch branch February 22, 2019 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429

Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429

davigonz commented Jan 23, 2019 •

edited by jesmrec

Loading

davigonz commented Jan 29, 2019 •

edited

Loading

hannesa2 commented Jan 29, 2019

hannesa2 commented Jan 29, 2019 •

edited

Loading

davigonz commented Feb 1, 2019

davigonz commented Feb 6, 2019

hosy commented Feb 12, 2019

davigonz commented Feb 12, 2019 •

edited

Loading

davigonz commented Feb 14, 2019

davigonz commented Feb 18, 2019

jesmrec commented Feb 21, 2019

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019

jesmrec commented Feb 22, 2019

Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429

Include switch to allow or disallow light filtering from other apps like Twilight or similars #2429

Conversation

davigonz commented Jan 23, 2019 • edited by jesmrec Loading

davigonz commented Jan 29, 2019 • edited Loading

hannesa2 commented Jan 29, 2019

hannesa2 commented Jan 29, 2019 • edited Loading

davigonz commented Feb 1, 2019

davigonz commented Feb 6, 2019

hosy commented Feb 12, 2019

davigonz commented Feb 12, 2019 • edited Loading

davigonz commented Feb 14, 2019

davigonz commented Feb 18, 2019

jesmrec commented Feb 21, 2019

jesmrec commented Feb 21, 2019 • edited Loading

(1) [FIXED]

jesmrec commented Feb 21, 2019 • edited Loading

(2) [FIXED]

jesmrec commented Feb 21, 2019 • edited Loading

(3) [FIXED]

jesmrec commented Feb 21, 2019 • edited Loading

(4) [FIXED]

jesmrec commented Feb 21, 2019 • edited Loading

(5) [FIXED]

jesmrec commented Feb 21, 2019

(6)

jesmrec commented Feb 22, 2019

davigonz commented Jan 23, 2019 •

edited by jesmrec

Loading

davigonz commented Jan 29, 2019 •

edited

Loading

hannesa2 commented Jan 29, 2019 •

edited

Loading

davigonz commented Feb 12, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading

jesmrec commented Feb 21, 2019 •

edited

Loading