-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix download/available offline icons #2152
Conversation
@theScrabi Do we really need |
No, that happened by exident. |
res/layout/grid_image.xml
Outdated
@@ -55,16 +55,7 @@ | |||
android:layout_marginTop="4dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly don't know, it just was that way before so I left it.
res/layout/grid_image.xml
Outdated
android:layout_marginBottom="4dp" | ||
android:layout_marginRight="4dp" | ||
android:src="@drawable/ic_available_offline" /> | ||
android:src="@drawable/sync_pin" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are replacing ic_available_offline
with sync_pin
, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because the image set here is just a place holder. The actual image gets set dynamically.
res/layout/grid_item.xml
Outdated
android:layout_marginBottom="2dp" | ||
android:layout_marginRight="2dp" | ||
android:src="@drawable/ic_available_offline" /> | ||
android:src="@drawable/sync_pin" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here ic_available_offline
with sync_pin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@theScrabi The code looks good for me but please delete |
Changes approved, ready to test |
(1)
Current: Once all the stuff info the folder is marked with the pink tick, the folder itself and its subfolders aren't Expected: If a folder is set as av. offline, the av. offline mark is also set in the folder icon Tested with Nexus 6P |
@jesmrec that should be fixed. |
(2)Steps:
Current: subfolders does not have the icons |
fixed issue for sub folder. |
Maybe we need here a bit of discussion, so i realised that we are losing one state. Before, the available offline mark was set on the bottom right of the icon, so in the top we set the "syncing" icon to show the user that the file is being synced at this moment: Right now, when the icon is set, no status is shown: so, we know that the item is av. offline, but not if it is being synced. Options to fix:
any other ideas will be welcome. |
@jesmrec : |
Approved |
fixes #2145 and #2081
BUGS & IMPROVEMENTS