-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1415 - semi transparent checkmark in checked checkbox image #1424
Conversation
Fine for me 👍 |
So pinging @jancborchardt @davivel and @masensio for further review and feedback |
c9207ea
to
b364206
Compare
b364206
to
bcd7672
Compare
d1811c2
to
f90320c
Compare
29a2936
to
387d0c8
Compare
@tobiasKaminsky should I just merge this into the multi select branch? Imho this makes sense so everything is in one PR because this is just a multi select checkbox fix for dark images in grid view mode. So it could be considered a known issue of a feature to been introduced yet so I would say we fix it before we even release the feature. What do you think? cc @rperezb |
It seems like a good idea to merge this within the multiple selection issue I was about to suggest a code review, till I see just images changed LOL 😆 @malkomich you have been working actively on this one, does it make sense to merge it? I will list this issue on the main issue: #1176 so that we take care of checking that they are shown fine within the devices cc @jesmrec |
@AndyScherzinger Could you make a rebase on master to merge it? It's a nice fix of design, Thanks! 😃 |
387d0c8
to
c490087
Compare
Hi @malkomich It is now rebased to latest master - feel free to merge 😃 |
c490087
to
8697491
Compare
Sorry for the incovenience @AndyScherzinger, I came when master got updated again. Anyways you can merge by yourself since you have my 👍 , to avoid the "out-of-date" checks. |
8697491
to
2fec9e8
Compare
For a detailed discussion please see #1415 since the material like checkboxes (also on master) are now used for multi selection also on grid view the selected items are hard to spot on dark images sind the box is dark blue and the checkmark has been transparent.
This PR changes the checked checkbox images with the checkmark being white with semi transparency so the checkmark can be spotted on selected grid items in case of dark images.