Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1415 - semi transparent checkmark in checked checkbox image #1424

Merged
merged 3 commits into from
Jun 2, 2016

Conversation

AndyScherzinger
Copy link
Contributor

For a detailed discussion please see #1415 since the material like checkboxes (also on master) are now used for multi selection also on grid view the selected items are hard to spot on dark images sind the box is dark blue and the checkmark has been transparent.
This PR changes the checked checkbox images with the checkmark being white with semi transparency so the checkmark can be spotted on selected grid items in case of dark images.

@tobiasKaminsky
Copy link
Contributor

Fine for me 👍

@AndyScherzinger
Copy link
Contributor Author

So pinging @jancborchardt @davivel and @masensio for further review and feedback

@AndyScherzinger AndyScherzinger mentioned this pull request Feb 4, 2016
22 tasks
@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch from c9207ea to b364206 Compare March 31, 2016 14:33
@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch from b364206 to bcd7672 Compare April 14, 2016 12:58
@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch 3 times, most recently from d1811c2 to f90320c Compare April 26, 2016 21:27
@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch 2 times, most recently from 29a2936 to 387d0c8 Compare May 9, 2016 11:30
@AndyScherzinger
Copy link
Contributor Author

@tobiasKaminsky should I just merge this into the multi select branch? Imho this makes sense so everything is in one PR because this is just a multi select checkbox fix for dark images in grid view mode. So it could be considered a known issue of a feature to been introduced yet so I would say we fix it before we even release the feature. What do you think?

cc @rperezb

@rperezb
Copy link

rperezb commented May 31, 2016

It seems like a good idea to merge this within the multiple selection issue

I was about to suggest a code review, till I see just images changed LOL 😆

@malkomich you have been working actively on this one, does it make sense to merge it? I will list this issue on the main issue: #1176 so that we take care of checking that they are shown fine within the devices cc @jesmrec

@AndyScherzinger AndyScherzinger changed the title semi transparent checkmark in checked checkbox image (see #1415) #1415 - semi transparent checkmark in checked checkbox image May 31, 2016
@malkomich
Copy link
Member

@AndyScherzinger Could you make a rebase on master to merge it?

It's a nice fix of design, Thanks! 😃

@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch from 387d0c8 to c490087 Compare June 1, 2016 13:07
@AndyScherzinger
Copy link
Contributor Author

Hi @malkomich It is now rebased to latest master - feel free to merge 😃

@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch from c490087 to 8697491 Compare June 1, 2016 17:08
@malkomich
Copy link
Member

Sorry for the incovenience @AndyScherzinger, I came when master got updated again.

Anyways you can merge by yourself since you have my 👍 , to avoid the "out-of-date" checks.

@AndyScherzinger AndyScherzinger force-pushed the 1415_checkbox_checkmark_colored branch from 8697491 to 2fec9e8 Compare June 2, 2016 11:39
@AndyScherzinger AndyScherzinger merged commit 9ce1dbc into master Jun 2, 2016
@AndyScherzinger AndyScherzinger deleted the 1415_checkbox_checkmark_colored branch June 2, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants